Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Prompt users whether to install optional dependencies #55

Open
mooziii opened this issue Jul 3, 2022 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@mooziii
Copy link
Contributor

mooziii commented Jul 3, 2022

title says it
Example:

Do you want to install any optional dependencies?
1) modrinth/modmenu
2) modrinth/clothconfig
3) modrinth/fabric-api

List the dependencies that you want to install (provide the numbers): 2,3

^^^
this would install clothconfig and fabric api but not modmenu

@jakobkmar jakobkmar added the enhancement New feature or request label Jul 6, 2022
@jakobkmar
Copy link
Owner

Do you think this prompt should be default behaviour or only appear with a special flag?

@mooziii
Copy link
Contributor Author

mooziii commented Jul 6, 2022

Should be default

@sparrowofsong
Copy link

I agree; I'm using quilt, which replaces fabric api with qsl if I'm not mistaken, so automatically installing fabric api (and not allowing the user to remove it) doesn't work well in that case

@jakobkmar
Copy link
Owner

@sparrowofsong that's another issue, fabric-api is not an optional dependency in that case, but a required one - this issue is about optional dependencies not being installed at all at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants