Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when calling "pacmc search better" #70

Open
nik875 opened this issue Aug 27, 2022 · 6 comments
Open

Exception when calling "pacmc search better" #70

nik875 opened this issue Aug 27, 2022 · 6 comments

Comments

@nik875
Copy link
Contributor

nik875 commented Aug 27, 2022

When using "better" as the search term, SerializationException is raised saying that ProjectType does not contain element with name 'resourcepack'. This bug exists in both main and release branches.

Full error message:

Searching with the given query 'better'
kotlinx.serialization.SerializationException: net.axay.pacmc.repoapi.modrinth.model.ServerRenderedProject.ProjectType does not contain element with name 'resourcepack'
at kotlinx.serialization.json.internal.JsonNamesMapKt.getJsonNameIndexOrThrow(JsonNamesMap.kt:63)
at kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeEnum(StreamingJsonDecoder.kt:265)
at net.axay.pacmc.repoapi.modrinth.model.ServerRenderedProject$ProjectType$$serializer.deserialize(ServerRenderedProject.kt:69)
at net.axay.pacmc.repoapi.modrinth.model.ServerRenderedProject$ProjectType$$serializer.deserialize(ServerRenderedProject.kt:69)
at kotlinx.serialization.json.internal.PolymorphicKt.decodeSerializableValuePolymorphic(Polymorphic.kt:59)
at kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeSerializableValue(StreamingJsonDecoder.kt:36)
at kotlinx.serialization.encoding.AbstractDecoder.decodeSerializableValue(AbstractDecoder.kt:43)
at kotlinx.serialization.encoding.AbstractDecoder.decodeSerializableElement(AbstractDecoder.kt:70)
at net.axay.pacmc.repoapi.modrinth.model.ProjectResult$$serializer.deserialize(ProjectResult.kt:10)
at net.axay.pacmc.repoapi.modrinth.model.ProjectResult$$serializer.deserialize(ProjectResult.kt:10)
at kotlinx.serialization.json.internal.PolymorphicKt.decodeSerializableValuePolymorphic(Polymorphic.kt:59)
at kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeSerializableValue(StreamingJsonDecoder.kt:36)
at kotlinx.serialization.encoding.AbstractDecoder.decodeSerializableValue(AbstractDecoder.kt:43)
at kotlinx.serialization.encoding.AbstractDecoder.decodeSerializableElement(AbstractDecoder.kt:70)
at kotlinx.serialization.encoding.CompositeDecoder$DefaultImpls.decodeSerializableElement$default(Decoding.kt:535)
at kotlinx.serialization.internal.ListLikeSerializer.readElement(CollectionSerializers.kt:80)
at kotlinx.serialization.internal.AbstractCollectionSerializer.readElement$default(CollectionSerializers.kt:51)
at kotlinx.serialization.internal.AbstractCollectionSerializer.merge(CollectionSerializers.kt:36)
at kotlinx.serialization.internal.AbstractCollectionSerializer.deserialize(CollectionSerializers.kt:43)
at kotlinx.serialization.json.internal.PolymorphicKt.decodeSerializableValuePolymorphic(Polymorphic.kt:59)
at kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeSerializableValue(StreamingJsonDecoder.kt:36)
at kotlinx.serialization.encoding.AbstractDecoder.decodeSerializableValue(AbstractDecoder.kt:43)
at kotlinx.serialization.encoding.AbstractDecoder.decodeSerializableElement(AbstractDecoder.kt:70)
at net.axay.pacmc.repoapi.modrinth.model.SearchResults$$serializer.deserialize(SearchResults.kt:8)
at net.axay.pacmc.repoapi.modrinth.model.SearchResults$$serializer.deserialize(SearchResults.kt:8)
at kotlinx.serialization.json.internal.PolymorphicKt.decodeSerializableValuePolymorphic(Polymorphic.kt:59)
at kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeSerializableValue(StreamingJsonDecoder.kt:36)
at kotlinx.serialization.internal.NullableSerializer.deserialize(NullableSerializer.kt:30)
at kotlinx.serialization.json.internal.PolymorphicKt.decodeSerializableValuePolymorphic(Polymorphic.kt:59)
at kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeSerializableValue(StreamingJsonDecoder.kt:36)
at kotlinx.serialization.json.Json.decodeFromString(Json.kt:100)
at net.axay.pacmc.repoapi.modrinth.ModrinthApi.searchProjects(ModrinthApi.kt:107)
at net.axay.pacmc.repoapi.modrinth.ModrinthApi$searchProjects$1.invokeSuspend(ModrinthApi.kt)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:570)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:749)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:677)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:664)

@btwonion
Copy link
Contributor

That's because of modrinth added plugins and resourcepacks which are currently unknown to pacmc. The same error happened in #67

@btwonion
Copy link
Contributor

i will fix it quick

@btwonion
Copy link
Contributor

should be fixed with #71

@Offroaders123
Copy link

I noticed this today with running pacmc search sodium, but interestingly not with pacmc search phosphor.

@WordlessEcho
Copy link

> pacmc search ConnectedTexturesMod

Searching with the given query 'ConnectedTexturesMod'
kotlinx.serialization.SerializationException: net.axay.pacmc.repoapi.modrinth.model.ServerRenderedProject.ProjectType does not contain element with name 'resourcepack'
        at kotlinx.serialization.json.internal.JsonNamesMapKt.getJsonNameIndexOrThrow(JsonNamesMap.kt:63)
        at kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeEnum(StreamingJsonDecoder.kt:265)
        at net.axay.pacmc.repoapi.modrinth.model.ServerRenderedProject$ProjectType$$serializer.deserialize(ServerRenderedProject.kt:69)
        at net.axay.pacmc.repoapi.modrinth.model.ServerRenderedProject$ProjectType$$serializer.deserialize(ServerRenderedProject.kt:69)
        at kotlinx.serialization.json.internal.PolymorphicKt.decodeSerializableValuePolymorphic(Polymorphic.kt:59)
        at kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeSerializableValue(StreamingJsonDecoder.kt:36)
        at kotlinx.serialization.encoding.AbstractDecoder.decodeSerializableValue(AbstractDecoder.kt:43)
        at kotlinx.serialization.encoding.AbstractDecoder.decodeSerializableElement(AbstractDecoder.kt:70)
        at net.axay.pacmc.repoapi.modrinth.model.ProjectResult$$serializer.deserialize(ProjectResult.kt:10)
        at net.axay.pacmc.repoapi.modrinth.model.ProjectResult$$serializer.deserialize(ProjectResult.kt:10)
        at kotlinx.serialization.json.internal.PolymorphicKt.decodeSerializableValuePolymorphic(Polymorphic.kt:59)
        at kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeSerializableValue(StreamingJsonDecoder.kt:36)
        at kotlinx.serialization.encoding.AbstractDecoder.decodeSerializableValue(AbstractDecoder.kt:43)
        at kotlinx.serialization.encoding.AbstractDecoder.decodeSerializableElement(AbstractDecoder.kt:70)
        at kotlinx.serialization.encoding.CompositeDecoder$DefaultImpls.decodeSerializableElement$default(Decoding.kt:535)
        at kotlinx.serialization.internal.ListLikeSerializer.readElement(CollectionSerializers.kt:80)
        at kotlinx.serialization.internal.AbstractCollectionSerializer.readElement$default(CollectionSerializers.kt:51)
        at kotlinx.serialization.internal.AbstractCollectionSerializer.merge(CollectionSerializers.kt:36)
        at kotlinx.serialization.internal.AbstractCollectionSerializer.deserialize(CollectionSerializers.kt:43)
        at kotlinx.serialization.json.internal.PolymorphicKt.decodeSerializableValuePolymorphic(Polymorphic.kt:59)
        at kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeSerializableValue(StreamingJsonDecoder.kt:36)
        at kotlinx.serialization.encoding.AbstractDecoder.decodeSerializableValue(AbstractDecoder.kt:43)
        at kotlinx.serialization.encoding.AbstractDecoder.decodeSerializableElement(AbstractDecoder.kt:70)
        at net.axay.pacmc.repoapi.modrinth.model.SearchResults$$serializer.deserialize(SearchResults.kt:8)
        at net.axay.pacmc.repoapi.modrinth.model.SearchResults$$serializer.deserialize(SearchResults.kt:8)
        at kotlinx.serialization.json.internal.PolymorphicKt.decodeSerializableValuePolymorphic(Polymorphic.kt:59)
        at kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeSerializableValue(StreamingJsonDecoder.kt:36)
        at kotlinx.serialization.internal.NullableSerializer.deserialize(NullableSerializer.kt:30)
        at kotlinx.serialization.json.internal.PolymorphicKt.decodeSerializableValuePolymorphic(Polymorphic.kt:59)
        at kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeSerializableValue(StreamingJsonDecoder.kt:36)
        at kotlinx.serialization.json.Json.decodeFromString(Json.kt:100)
        at net.axay.pacmc.repoapi.modrinth.ModrinthApi.searchProjects(ModrinthApi.kt:107)
        at net.axay.pacmc.repoapi.modrinth.ModrinthApi$searchProjects$1.invokeSuspend(ModrinthApi.kt)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
        at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:570)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:749)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:677)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:664)

@jakobkmar
Copy link
Owner

@WordlessEcho thank you for providing the excpetion

This project is currently not being actively worked on (due to lack of time on my side).

Since the official Modrinth App provides some similiar functionality, I think it is a good replacement for the time being https://modrinth.com/app (it also has a CLI).

I'll add a notice to the readme of this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants