Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow URLs to be blocked #144

Open
mitchhentges opened this issue Feb 24, 2016 · 2 comments
Open

Allow URLs to be blocked #144

mitchhentges opened this issue Feb 24, 2016 · 2 comments

Comments

@mitchhentges
Copy link
Member

Allow a "blacklist" of URLs that shouldn't be loaded.

@nerdbeere, this is sourced from the list of issues in #1.
What content should the consumer get? Maybe a simple response with code 502? Maybe 451 😉?

@nerdbeere
Copy link
Member

I think the initial idea was to emulate the behavior of adblockers. They use an extension api to block requests which we can't do as we don't have access to the browser. It doesn't really matter which code we send, everything could lead to an unexpected result here. Depending on the application catching the error.

@mitchhentges
Copy link
Member Author

Hmm, we could just cancel the connection, I believe that that's how Ad-blockers "do". At least Ublock Origin causes a net::ERR_BLOCKED_BY_CLIENT error in the console:
2017-06-03-120458_789x152_scrot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants