-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for import/export of 'mappings' #375
Comments
Any thoughts on this? |
Hey, sorry for the delay 😅
Hmm, if we supported appending, I'd be worried about how we'd handle conflicts between new mappings and existing ones 🤔
IMHO the cleanest thing would be to:
This way, we shouldn't run into a case where a mapping batch is partially imported, since that shouldn't be as useful as a fully-imported batch (kinda like how a database transaction with a failure in the middle probably isn't useful 😆)
Hmm, I don't have any crisp ideas, perhaps @tomitm might want to chime in. I'm leaning towards having buttons (import, export) in the same line as the "URL TO URL" and "URL TO FILE" buttons that will put the users through the workflow (and each step would be their own views).
We could start by making it a full-export, then looping back to subset-export if there's demand by users (or your team!) |
@mitchhentges Thanks for the feedback. If I get some responses re: each of the points above, is this something that I can take on? |
I'd absolutely ❤️ some PRs! I've caught up on a side project, so (theoretically) I should ensure that the turnaround time on reviewing isn't as bad as it's been! So, absolutely, if you're excited to take this on, then I'll be excited to release it 😄 |
@mitchhentges Sounds great. Before I collect our notes into success criteria, I have a suggestion re: where we can expose this functionality to the user. How would you feel about a dedicated 'Import/Export' tab and view (ie. to appear beside the existing 'Mappings' tab)? On this view we could expose the option to import or export mappings to/from a file, or via copy/paste. If it would help, I can spin up a quick UI mock? |
I'm a little worried that it would appear independent from "Mappings" (e.g. looks as if it's app-wide import/export). However, maybe that's not a downside, since technically the only configurable state in James is the mappings! I think that your solution is better than trying to shoehorn an import/export onto the Mappings tab. Sounds phenomenal 👍 😄 |
@mitchhentges Apologies, I haven't had a chance to get started on this. I will touch base this week. |
Proposal:
Currently, URL 'mappings' must be added and removed one-by-one. As a user, I'd like the ability to import and export batches of mappings.
Use Case:
This would allow teams of developers (mine included) to share common mappings via version control.
To Consider:
I'd be happy to take a crack at this.
The text was updated successfully, but these errors were encountered: