Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about method overwrites #12

Closed
kbarros opened this issue Oct 1, 2024 · 3 comments
Closed

Warning about method overwrites #12

kbarros opened this issue Oct 1, 2024 · 3 comments

Comments

@kbarros
Copy link

kbarros commented Oct 1, 2024

This package seems to require FilePathsBase to load files. Precompiling the two packages together seems to give the following warnings:

WARNING: Method definition (::Type{URIs.URI})(FilePathsBase.AbstractPath) in module FilePaths at /home/runner/.julia/packages/FilePaths/ULnpu/src/uris.jl:5 overwritten in module CrystalInfoFramework at /home/runner/.julia/packages/CrystalInfoFramework/FpKpL/src/ddlm_dictionary_ng.jl:1304.
WARNING: Method definition kwcall(NamedTuple{names, T} where T<:Tuple where names, Type{URIs.URI}, FilePathsBase.AbstractPath) in module FilePaths at /home/runner/.julia/packages/FilePaths/ULnpu/src/uris.jl:5 overwritten in module CrystalInfoFramework at /home/runner/.julia/packages/CrystalInfoFramework/FpKpL/src/ddlm_dictionary_ng.jl:1304.

See, for example, the output of julia-runtest here:
https://github.com/SunnySuite/Sunny.jl/actions/runs/11115137251/job/30882999280

@kbarros
Copy link
Author

kbarros commented Oct 1, 2024

Maybe the ideal solution is to remove the FilePaths dependency, and expect the file path as a string. This would be more Julian, and aligns with previous comment here: #10 (comment)

@jamesrhester
Copy link
Owner

Hmm, looks like I've indulged in some type piracy. I agree that it is time to revert to intepreting strings in the constructor as file paths rather than a piece of CIF.

@jamesrhester
Copy link
Owner

Just-released v0.7.0 removes FilePaths. It will still accept Path objects in the Cif constructor, but now an AbstractString is interpreted as a filename instead of CIF-formatted content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants