-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the performance-tests into separate units #5
Comments
It is curious that stuff gets reused despite providing |
Even netty is reused, independent of zio framework. yes, this needs investigation/documentation, but for now (with the limited bounty/time budget), the workaround to enable just one test does it https://github.com/abebeos/zio-http-client-perf/blob/main/src/main/scala/App.scala Final solution to keep speedtests in different files would be more elegant though. Up to you to apply it on your code here. |
And as a sidenote: the problem is mostly with the development-mentality of the zio project. Things are not strict enough, e.g. the speedtests should be already there, right within the CI, ideally with regression-alarms and comparative-alarms (e.g. "if zio is over 50% slower that java-http, alarm"). Anyways, me out at this point, I do not expect to get even an ok for a bounty claim (voices: "where is your PR?"). |
latest results are too good:
This is because the different
runstest-requests reuse earlier instantiated stuff.Reproduce
Workaround
Solution
The text was updated successfully, but these errors were encountered: