Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ${{ hashFiles('...','...') }} for Po4a cache #882

Open
ann0see opened this issue Dec 22, 2022 · 1 comment
Open

Use ${{ hashFiles('...','...') }} for Po4a cache #882

ann0see opened this issue Dec 22, 2022 · 1 comment

Comments

@ann0see
Copy link
Member

ann0see commented Dec 22, 2022

As #873 was merged, I hinted to the fact that we should improve how the cache keys are named. We should use a similar approach like in the main repo. Autobuild has e.g. ${{ hashFiles('.github/workflows/autobuild.yml', '.github/autobuild/mac.sh', 'mac/deploy_mac.sh') }}

I'd assume we can also use something like that but with a reference (how? Probably hashing the file where the url is encoded is enough) to the po4a deb.

@ann0see ann0see added bug Something isn't working and removed bug Something isn't working labels Dec 22, 2022
@ann0see ann0see added this to the Release 3.10.0 milestone Dec 22, 2022
@pljones
Copy link
Contributor

pljones commented Apr 19, 2023

I'm moving this to Triage and removing the milestone as no one is assigned to get it done.

@pljones pljones removed this from the Release 3.10.0 milestone Apr 19, 2023
@ann0see ann0see added this to Tracking Jul 1, 2023
@github-project-automation github-project-automation bot moved this to Triage in Tracking Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

2 participants