Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idea: Improve code block UX in streaming responses #3713

Closed
5 tasks done
imtuyethan opened this issue Sep 21, 2024 · 4 comments · Fixed by #4010
Closed
5 tasks done

idea: Improve code block UX in streaming responses #3713

imtuyethan opened this issue Sep 21, 2024 · 4 comments · Fixed by #4010
Assignees
@urmauur
Labels
category: threads & chat Threads & chat UI UX issues type: enhancement Improves a current feature
Milestone
v0.5.9

Comments

@imtuyethan
Copy link
Contributor

imtuyethan commented Sep 21, 2024 •
edited by urmauur
Loading

Problem Statement

https://discord.com/channels/1107178041848909847/1286613318659997697
Currently, users face several issues when trying to copy code blocks during streaming responses:

  • Markdown formatting problems, especially with lists
  • Can't copy code while the response is still streaming
  • Copy icon is too small and hard to click

Feature Idea

  • Investigate and fix markdown formatting issues
  • Enable copying of code blocks mid-stream, similar to ChatGPT's functionality
  • Increase the size of the copy icon to improve clickability
  • Implement a mechanism to properly register click events during streaming updates?
  • bug: [UI Bug] Code block - Copy icon alignment issue #3990

Design

Code block design

https://www.figma.com/design/DYfpMhf8qiSReKvYooBgDV/Jan-App-(3rd-version)?node-id=8910-70486&t=lR7dmL29vsk85Zf5-4

Screenshot 2024-11-04 at 4 32 54 PM
@imtuyethan imtuyethan added the type: enhancement Improves a current feature label Sep 21, 2024
@imtuyethan
Copy link
Contributor Author

Screenshot 2024-09-23 at 11 16 37 AM

@0xSage 0xSage added the category: threads & chat Threads & chat UI UX issues label Oct 14, 2024
@0xSage 0xSage moved this to Scheduled in Jan & Cortex Oct 15, 2024
@imtuyethan imtuyethan mentioned this issue Oct 29, 2024
Open
@imtuyethan imtuyethan added the needs designs Needs designs label Nov 1, 2024
@imtuyethan
Copy link
Contributor Author

Screenshot 2024-11-01 at 4 52 40 PM

@imtuyethan imtuyethan added this to the v0.5.8 milestone Nov 4, 2024
@imtuyethan imtuyethan removed their assignment Nov 5, 2024
@imtuyethan imtuyethan removed the needs designs Needs designs label Nov 5, 2024
@imtuyethan imtuyethan modified the milestones: v0.5.8, v0.5.9 Nov 6, 2024
This was referenced Nov 13, 2024
Closed
Merged
@github-project-automation github-project-automation bot moved this from In Review to Review + QA in Jan & Cortex Nov 14, 2024
@imtuyethan imtuyethan reopened this Nov 20, 2024
@github-project-automation github-project-automation bot moved this from Review + QA to In Progress in Jan & Cortex Nov 20, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Review + QA in Jan & Cortex Nov 20, 2024
@imtuyethan imtuyethan reopened this Nov 20, 2024
@github-project-automation github-project-automation bot moved this from Review + QA to In Progress in Jan & Cortex Nov 20, 2024
@imtuyethan
Copy link
Contributor Author

imtuyethan commented Nov 20, 2024 •
edited
Loading

@urmauur I still can't copy code while the response is still streaming:

Screen.Recording.2024-11-20.at.10.31.33.PM.mov

@urmauur
Copy link
Member

urmauur commented Nov 21, 2024

@imtuyethan it's should fix, on this PR #4061 help me test again

@github-project-automation github-project-automation bot moved this from In Review to Review + QA in Jan & Cortex Nov 21, 2024
@imtuyethan imtuyethan moved this from Review + QA to Completed in Jan & Cortex Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@urmauur urmauur

Labels
category: threads & chat Threads & chat UI UX issues type: enhancement Improves a current feature
Projects
Jan & Cortex
Status: Completed
Milestone
v0.5.9
Development

Successfully merging a pull request may close this issue.

feat: new UI code block and Enable copying of code blocks or plain text mid-stream janhq/jan
3 participants
@urmauur @0xSage @imtuyethan