Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve auto generated conditional class names #161

Open
jantimon opened this issue Sep 26, 2024 · 0 comments
Open

improve auto generated conditional class names #161

jantimon opened this issue Sep 26, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jantimon
Copy link
Owner

right now we generate class names for binary expressions

e.g.

const Button styled.button`
  ${({$primary}) => $primary ? css`color:red` : css`color:blue`};
`

becomes Button__primary or Button__not-primary

we should also extend that for string and number values

e.g.:

const Button styled.button`
  ${({$variant}) => $variant === 'primary' ? css`color:red` : css`color:blue`};
`

could become Button__variant-primary or Button__variant-not-primary

@jantimon jantimon added the enhancement New feature or request label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant