fix(audit-log-node): optimise for the new backend and remove deprecat…

…ions (#2283)

fix(audit-log-node): optimize for the new backend and remove deprecations

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

plugins/audit-log-node/package.json

@@ -30,9 +30,13 @@
     "tsc": "tsc"
   },
   "devDependencies": {
-    "@backstage/backend-common": "0.23.3",
+    "@backstage/backend-plugin-api": "^0.7.0",
     "@backstage/backend-test-utils": "0.4.4",
     "@backstage/cli": "0.26.11",
+    "@backstage/errors": "^1.2.4",
+    "@backstage/types": "^1.1.1",
+    "@types/lodash": "4.17.5",
+    "express": "^4.19.2",
     "jest-express": "1.12.0"
   },
   "files": [
@@ -52,10 +56,6 @@
   "homepage": "https://red.ht/rhdh",
   "bugs": "https://github.com/janus-idp/backstage-plugins/issues",
   "dependencies": {
-    "@backstage/backend-plugin-api": "^0.7.0",
-    "@backstage/errors": "^1.2.4",
-    "@backstage/types": "^1.1.1",
-    "express": "^4.19.2",
     "lodash": "^4.17.21"
   },
   "maintainers": [

plugins/audit-log-node/src/DefaultAuditLogger.test.ts

@@ -1,13 +1,12 @@
-import { getVoidLogger } from '@backstage/backend-common';
 import { mockCredentials, mockServices } from '@backstage/backend-test-utils';
 
-import { Request } from 'express';
+import type { Request } from 'express';
 import { Request as JestRequest } from 'jest-express/lib/request';
 
 import { DefaultAuditLogger } from './DefaultAuditLogger';
 
 describe('DefaultAuditLogger', () => {
-  const logger = getVoidLogger();
+  const logger = mockServices.logger.mock();
   const loggerSpy: jest.SpyInstance = jest.spyOn(logger, 'info');
   const loggerErrorSpy: jest.SpyInstance = jest.spyOn(logger, 'error');
 

plugins/audit-log-node/src/DefaultAuditLogger.ts

@@ -1,12 +1,12 @@
-import {
+import type {
   AuthService,
   HttpAuthService,
   LoggerService,
 } from '@backstage/backend-plugin-api';
-import { ErrorLike } from '@backstage/errors';
-import { JsonObject, JsonValue } from '@backstage/types';
+import type { ErrorLike } from '@backstage/errors';
+import type { JsonObject, JsonValue } from '@backstage/types';
 
-import { Request } from 'express';
+import type { Request } from 'express';
 import { cloneDeep } from 'lodash';
 
 import {

plugins/audit-log-node/src/types.ts

@@ -1,12 +1,12 @@
-import {
+import type {
   AuthService,
   HttpAuthService,
   LoggerService,
 } from '@backstage/backend-plugin-api';
-import { ErrorLike } from '@backstage/errors';
-import { JsonValue } from '@backstage/types';
+import type { ErrorLike } from '@backstage/errors';
+import type { JsonValue } from '@backstage/types';
 
-import { Request } from 'express';
+import type { Request } from 'express';
 
 export type ActorDetails = {
   actorId: string | null;