From 3aa53ea8297b615ed6afd727708d71b738fc5708 Mon Sep 17 00:00:00 2001
From: Jan Vrany <jan.vrany@labware.com>
Date: Fri, 20 Oct 2023 21:23:39 +0100
Subject: [PATCH] POWER: refactor `?load` evaluators

...to use common helper.
---
 .../TRPPC64CodeEvaluator.class.st             | 52 ++++++++++++++++---
 1 file changed, 46 insertions(+), 6 deletions(-)

diff --git a/src/Tinyrossa-POWER/TRPPC64CodeEvaluator.class.st b/src/Tinyrossa-POWER/TRPPC64CodeEvaluator.class.st
index a4eec53..ad9cfbb 100644
--- a/src/Tinyrossa-POWER/TRPPC64CodeEvaluator.class.st
+++ b/src/Tinyrossa-POWER/TRPPC64CodeEvaluator.class.st
@@ -2,22 +2,57 @@ Class {
 	#name : #TRPPC64CodeEvaluator,
 	#superclass : #TRCodeEvaluator,
 	#pools : [
+		'TRDataTypes',
 		'TRPPC64RegisterKinds',
 		'TRPPC64Registers'
 	],
 	#category : #'Tinyrossa-POWER-Codegen'
 }
 
+{ #category : #'evaluation-helpers' }
+TRPPC64CodeEvaluator >> commonLoad: node [
+	"Handles aload, lload, iload, sload & bload"  
+
+	| dstReg offset type |
+
+	offset := (AcDSLSymbol value: node symbol name).
+	dstReg := codegen allocateRegister.
+
+	type := node type.
+	(type == Address or:[type == Int64]) ifTrue:[
+		self shouldImplement
+	] ifFalse:[ type == Int32 ifTrue:[
+		 generate
+			lwz: dstReg, (gr1 + offset).             
+	] ifFalse:[ type == Int16 ifTrue:[
+		self shouldImplement
+	] ifFalse:[ type == Int8 ifTrue:[
+		self shouldImplement
+	]]]].
+
+	^dstReg.
+]
+
 { #category : #evaluation }
 TRPPC64CodeEvaluator >> evaluate_aconst: node [
 	^self evaluate_lconst: node
 ]
 
+{ #category : #evaluation }
+TRPPC64CodeEvaluator >> evaluate_aload: node [
+	^ self commonLoad: node
+]
+
 { #category : #evaluation }
 TRPPC64CodeEvaluator >> evaluate_bconst: node [
 	^ self evaluate_iconst: node
 ]
 
+{ #category : #evaluation }
+TRPPC64CodeEvaluator >> evaluate_bload: node [
+	^ self commonLoad: node
+]
+
 { #category : #evaluation }
 TRPPC64CodeEvaluator >> evaluate_goto: node [
 	generate b: node symbol.
@@ -132,12 +167,7 @@ TRPPC64CodeEvaluator >> evaluate_ificmpne: node [
 
 { #category : #evaluation }
 TRPPC64CodeEvaluator >> evaluate_iload: node [
-	| symbol dstReg |
-
-	symbol := node symbol.
-	dstReg := codegen allocateRegister.
-	generate lwz: dstReg, (gr1 + (AcDSLSymbol value: symbol name)).
-	^ dstReg
+	^ self commonLoad: node
 ]
 
 { #category : #evaluation }
@@ -194,7 +224,17 @@ TRPPC64CodeEvaluator >> evaluate_lconst: node [
 	^ dstReg
 ]
 
+{ #category : #evaluation }
+TRPPC64CodeEvaluator >> evaluate_lload: node [
+	^ self commonLoad: node
+]
+
 { #category : #evaluation }
 TRPPC64CodeEvaluator >> evaluate_sconst: node [
 	^ self evaluate_iconst: node
 ]
+
+{ #category : #evaluation }
+TRPPC64CodeEvaluator >> evaluate_sload: node [
+	^ self commonLoad: node
+]