From d1811ead13998bbaed76b25fa9049897b82719bd Mon Sep 17 00:00:00 2001
From: Jared Wray <me@jaredwray.com>
Date: Fri, 6 Dec 2024 09:13:05 -0800
Subject: [PATCH] fixing linting on parameter properties

---
 package.json                        | 1 -
 src/providers/aws-ses.ts            | 1 +
 src/providers/aws-sms.ts            | 1 +
 src/providers/aws-sns.ts            | 1 +
 src/providers/firebase-messaging.ts | 3 ++-
 test/testing-data.ts                | 1 +
 6 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/package.json b/package.json
index 4d6ae5d..323cc91 100644
--- a/package.json
+++ b/package.json
@@ -56,7 +56,6 @@
   "xo": {
     "rules": {
       "@typescript-eslint/naming-convention": 0,
-      "@typescript-eslint/parameter-properties": 0,
       "@typescript-eslint/no-unsafe-call": 0,
       "@typescript-eslint/no-unsafe-assignment": 0,
       "@typescript-eslint/no-unsafe-return": 0,
diff --git a/src/providers/aws-ses.ts b/src/providers/aws-ses.ts
index e0765ba..76879bc 100644
--- a/src/providers/aws-ses.ts
+++ b/src/providers/aws-ses.ts
@@ -6,6 +6,7 @@ export class AWSSES implements ProviderInterface {
 	client: SESClient;
 	name = 'aws-ses';
 	type = AirhornProviderType.SMTP;
+	// eslint-disable-next-line @typescript-eslint/parameter-properties
 	region?: string;
 
 	constructor(region?: string) {
diff --git a/src/providers/aws-sms.ts b/src/providers/aws-sms.ts
index 0f8448c..bad664c 100644
--- a/src/providers/aws-sms.ts
+++ b/src/providers/aws-sms.ts
@@ -6,6 +6,7 @@ export class AWSSMS implements ProviderInterface {
 	client: SNS;
 	name = 'aws-sms';
 	type = AirhornProviderType.SMS;
+	// eslint-disable-next-line @typescript-eslint/parameter-properties
 	region?: string;
 
 	constructor(region?: string) {
diff --git a/src/providers/aws-sns.ts b/src/providers/aws-sns.ts
index 0253310..ba74e3a 100644
--- a/src/providers/aws-sns.ts
+++ b/src/providers/aws-sns.ts
@@ -6,6 +6,7 @@ export class AWSSNS implements ProviderInterface {
 	client: SNS;
 	name = 'aws-sns';
 	type = AirhornProviderType.MOBILE_PUSH;
+	// eslint-disable-next-line @typescript-eslint/parameter-properties
 	region?: string;
 
 	constructor(region?: string) {
diff --git a/src/providers/firebase-messaging.ts b/src/providers/firebase-messaging.ts
index e3b1d8c..bed7809 100644
--- a/src/providers/firebase-messaging.ts
+++ b/src/providers/firebase-messaging.ts
@@ -8,7 +8,8 @@ export class FirebaseMessaging implements ProviderInterface {
 	name = 'firebase-messaging';
 	type = AirhornProviderType.MOBILE_PUSH;
 
-	private readonly cert: string;
+	// eslint-disable-next-line @typescript-eslint/parameter-properties
+	cert: string;
 
 	constructor(cert: string) {
 		this.cert = cert;
diff --git a/test/testing-data.ts b/test/testing-data.ts
index b32f8c2..85f305d 100644
--- a/test/testing-data.ts
+++ b/test/testing-data.ts
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/parameter-properties */
 import {AirhornTemplate, AirhornTemplateText} from '../src/template.js';
 
 export class TestingData {