Skip to content
This repository has been archived by the owner on Jul 20, 2019. It is now read-only.

Update tests #18

Open
jarrodldavis opened this issue Jul 1, 2017 · 0 comments
Open

Update tests #18

jarrodldavis opened this issue Jul 1, 2017 · 0 comments
Milestone

Comments

@jarrodldavis
Copy link
Owner

jarrodldavis commented Jul 1, 2017

Probot's authors have made it easier to write tests for plugins, so probot-gpg should update applicable tests to match. Here's an example of updated tests in the official autoresponder plugin.

Additionally, more cases (where some or all commits aren't verified) need to be tested in the full integration suite.

Furthermore, now that more options are being added to the app, the tests are getting annoyingly repetitive. A data-driven approach should be take to generate test cases instead of duplicating test code.

@jarrodldavis jarrodldavis self-assigned this Sep 4, 2017
@jarrodldavis jarrodldavis removed their assignment Oct 1, 2017
@jarrodldavis jarrodldavis changed the title Update Tests Update tests Oct 9, 2017
@jarrodldavis jarrodldavis modified the milestones: v0.5.0, v0.6.0 Oct 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant