-
Notifications
You must be signed in to change notification settings - Fork 10
Sometimes GPG check fails, even though all commits are verified #59
Comments
Hmm... interesting. It doesn't look like the cause is a rebase since the 2-commit PR doesn't look like it was force pushed so I'm not sure what's going on. I'll need to add logging (#45) to get more information about what the app sees so I can track it down. Thanks for reporting the issue. |
@jarrodldavis Sounds good. Thank you for looking into it and let me know if you need anything else from me. |
Hey @rallytime, I just merged #61 into |
This gets even weirder… saltstack/salt#44253 and saltstack/salt#44259 have been updates with saltstack/salt#43379 remains failed, though. |
Hmm, so I saw a couple more pull requests with the issue today. It appears the initial open was marked as @rallytime do you think you could switch the saltstack/salt repo over to the development deployment so I can catch the logs when this happens? |
@jarrodldavis - yes, I will look into getting the development deployment installed today. |
Ok, I have switched those over now on the https://github.com/saltstack/salt repo. Please let me know if there is anything else I can help with. :) |
After more investigation, there appears to be an issue with the GitHub API after a pull request is updated with additional commits. My assumption is that when a pull request (or probably a branch in general) is pushed to, GitHub's signature verification service re-verifies all of the commits, and there's a delay between when the webhook is sent in response to the push and when the verification service completes. |
Is there a way to handle the delayed response/verification service when a pull request receives a push? |
Other than hard coding a delay when receiving a I've reached out to GitHub Support about the issue and they've followed up with some requests for more info, so hopefully we can track down the cause of the problem. I'll keep you updated. |
@jarrodldavis Thanks for looking into it! I look forward to any updates. |
I am not sure why, but occasionally I see the GPG check fail, even though all of the individual commits are verified.
Here are some examples:
At first I thought it might have something to do with the shear number of commits in a PR because I thought i was seeing them fail only on PRs with many commits. However, that doesn't appear to be the case since I found a PR today that only had 2 commits in it.
The text was updated successfully, but these errors were encountered: