-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typing improvement: Preserve the wrapped callable's signature in jax.jit
#23719
Labels
enhancement
New feature or request
Comments
lebrice
added a commit
to lebrice/jax
that referenced
this issue
Sep 18, 2024
- Fix for jax-ml#23719 Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Crossref #14688, which was a previous attempt to solve this. |
lebrice
added a commit
to lebrice/jax
that referenced
this issue
Sep 18, 2024
- Fix for jax-ml#23719 Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
lebrice
added a commit
to lebrice/jax
that referenced
this issue
Sep 18, 2024
- Fix for jax-ml#23719 Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
lebrice
added a commit
to lebrice/jax
that referenced
this issue
Sep 18, 2024
- Fix for jax-ml#23719 Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
lebrice
added a commit
to lebrice/jax
that referenced
this issue
Sep 19, 2024
- Fix for jax-ml#23719 Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
lebrice
added a commit
to lebrice/jax
that referenced
this issue
Sep 19, 2024
- Fix for jax-ml#23719 Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
lebrice
added a commit
to lebrice/jax
that referenced
this issue
Sep 21, 2024
- Fix for jax-ml#23719 Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
lebrice
added a commit
to lebrice/jax
that referenced
this issue
Sep 21, 2024
- Fix for jax-ml#23719 Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
lebrice
added a commit
to lebrice/jax
that referenced
this issue
Sep 21, 2024
- Fix for jax-ml#23719 Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
lebrice
added a commit
to lebrice/jax
that referenced
this issue
Sep 21, 2024
- Fix for jax-ml#23719 Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
lebrice
added a commit
to lebrice/jax
that referenced
this issue
Sep 21, 2024
- Fix for jax-ml#23719 Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
lebrice
added a commit
to lebrice/jax
that referenced
this issue
Sep 26, 2024
- Fix for jax-ml#23719 Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello there. Simple feature request / bug report:
Currently,
jax.jit
drops the typing signature of the wrapped callable.For example this code shows no warnings in a code editor:
Same goes for functions or methods annotated with a
functools.partial
ofjax.jit
: The signature of the wrapped callable is dropped:Is there something I'm not aware of that might make this undesirable for some reason?
In the meantime, I made #23720 to address this.
Let me know what you think :)
The text was updated successfully, but these errors were encountered: