Replace disable_backends with enable_backends on jax_multiplatform_test. #23953
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_679219675
branch
from
23ef16b
to
93f5948
Compare
copybara-service
bot
force-pushed
the
test_679219675
branch
from
93f5948
to
26632fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace disable_backends with enable_backends on jax_multiplatform_test.
Most users of disable_backends were actually using it to enable only a single backend. So things are simpler if we negate the sense of the option to say that. Change disable_configs to enable_configs, with a default
Nonevalue meaning "everything is enabled".We change the relationship between enable_backends, disable_configs, enable_configs to be the following:
enable_backendsselects a set of initial test configurations to enable, based off backend only.disable_configsthen prunes that set of test configurations, removing elements from the set.enable_configsthen adds additional configurations to the set.Fix code in jax/experimental/mosaic/gpu/examples not to depend on a Google-internal GPU support target.