-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to a high and low price calculation is even better #8
Comments
+1 for this |
I think I've got time to implement this; should I make a PR, @jbn? |
Is there any implementation of this? Please share. Thank you!!! |
See #11 |
I've been pretty burnt out on all my OSS stuff but my brain is recovering. I'm going to try and integrate @flowtrader2016 work this weekend. Sorry for the...checks notes...multi year delay |
Without having read the fixes proposed yet, my concern at the time of initial implementation was: you don't know if the high came before the low in the day, so there can be some temporal issues? Not sure if that is correct though gotta think about it |
Okay, took longer than expected, but I upgraded the build system so it's not a pain to develop on. New version is now Now that I have the build system set up, I'll see what i can add. |
Generally, ZigZag is calculated using the high and low prices in the candle diagram. How can code be applied to high and low prices? If high and low prices are calculated separately and combined, the performance will be much lower.
The text was updated successfully, but these errors were encountered: