Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to a high and low price calculation is even better #8

Open
traddo opened this issue Feb 5, 2020 · 7 comments
Open

Upgrade to a high and low price calculation is even better #8

traddo opened this issue Feb 5, 2020 · 7 comments

Comments

@traddo
Copy link

traddo commented Feb 5, 2020

Generally, ZigZag is calculated using the high and low prices in the candle diagram. How can code be applied to high and low prices? If high and low prices are calculated separately and combined, the performance will be much lower.

@quantfiction
Copy link

+1 for this

@HumanRupert
Copy link

I think I've got time to implement this; should I make a PR, @jbn?

@pepeto
Copy link

pepeto commented Apr 11, 2022

Is there any implementation of this? Please share. Thank you!!!

@flowtrader2016
Copy link

See #11

@jbn
Copy link
Owner

jbn commented Apr 21, 2022

I've been pretty burnt out on all my OSS stuff but my brain is recovering. I'm going to try and integrate @flowtrader2016 work this weekend. Sorry for the...checks notes...multi year delay

@jbn
Copy link
Owner

jbn commented Apr 21, 2022

Without having read the fixes proposed yet, my concern at the time of initial implementation was: you don't know if the high came before the low in the day, so there can be some temporal issues? Not sure if that is correct though gotta think about it

@jbn
Copy link
Owner

jbn commented Jul 31, 2022

Okay, took longer than expected, but I upgraded the build system so it's not a pain to develop on. New version is now 0.3.0. Seems like this is an old feature request. (E.g. #1) IIRC, I didn't implement this because there is an ambiguity with which came first the high or the low and under some circumstances, that requires a careful decision.

Now that I have the build system set up, I'll see what i can add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants