Skip to content

Latest commit

 

History

History
119 lines (91 loc) · 5.26 KB

CONTRIBUTING.rst

File metadata and controls

119 lines (91 loc) · 5.26 KB
Raw

Reporting Issues/Bugs

Thanks for reporting issues to ARTIQ! You can also discuss issues and ask questions on IRC (the #m-labs channel on OFTC), the Mattermost chat, or on the forum.

The best bug reports are those which contain sufficient information. With accurate and comprehensive context, an issue can be resolved quickly and efficiently. Please consider adding the following data to your issue report if possible:

  • A clear and unique summary that fits into one line. Also check that this issue has not yet been reported. If it has, add additional information there.
  • Precise steps to reproduce (list of actions that leads to the issue)
  • Expected behavior (what should happen)
  • Actual behavior (what happens instead)
  • Logging message, trace backs, screen shots where relevant
  • Components involved (omit irrelevant parts):
    • Operating System
    • ARTIQ version (with recent versions of ARTIQ, run artiq_client --version)
    • Version of the gateware and runtime loaded in the core device (in the output of artiq_coremgmt -D .... log)
    • If using Conda, output of conda list
    • Hardware involved

For in-depth information on bug reporting, see:

http://www.chiark.greenend.org.uk/~sgtatham/bugs.html https://developer.mozilla.org/en-US/docs/Mozilla/QA/Bug_writing_guidelines

Contributing Code

ARTIQ welcomes contributions. Write bite-sized patches that can stand alone, clean them up, write proper commit messages, add docstrings and unittests. Then git rebase them onto the current master or merge the current master. Verify that the testsuite passes. Then submit a pull request. Expect your contribution to be held up to coding standards (e.g. use flake8 to check yourself).

Checklist for Code Contributions

  • Test your changes or have someone test them. Mention what was tested and how.
  • Use correct spelling and grammar. Use your code editor to help you with syntax, spelling, and style
  • Style: PEP-8 (flake8)
  • Add, check docstrings and comments
  • Split your contribution into logically separate changes (git rebase --interactive). Merge (squash, fixup) commits that just fix previous commits or amend them. Remove unintended changes. Clean up your commits.
  • Check the copyright situation of your changes and sign off your patches (git commit --signoff, see also below)
  • Write meaningful commit messages containing the area of the change and a concise description (50 characters or less) in the first line. Describe everything else in the long explanation.
  • Review each of your commits for the above items (git show)
  • Update RELEASE_NOTES.md if there are noteworthy changes, especially if there are changes to existing APIs
  • Check, test, and update the documentation in doc/
  • Check, test, and update the unittests
  • Close and/or update issues

Copyright and Sign-Off

Authors retain copyright of their contributions to ARTIQ, but whenever possible should use the GNU LGPL version 3 license for them to be merged.

Works of US government employees are not copyrighted but can also be merged.

We've introduced a "sign-off" procedure on patches that are being sent around.

The sign-off is a simple line at the end of the explanation for the patch, which certifies that you wrote it or otherwise have the right to pass it on as an open-source patch. The rules are pretty simple: if you can certify the below:

Developer's Certificate of Origin (1.1 from the Linux kernel)

By making a contribution to this project, I certify that:

  1. The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
  2. The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
  3. The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
  4. I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

then you just add a line saying

Signed-off-by: Random J Developer <random@developer.example.org>

using your legal name (sorry, no pseudonyms or anonymous contributions.)

ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under GNU LGPL version 3 or later.