Skip to content

Latest commit

 

History

History
21 lines (15 loc) · 1.22 KB

pull_request_template.md

File metadata and controls

21 lines (15 loc) · 1.22 KB
Raw

Explanation of the changes, what they achieve, and any design decisions that are worth mentioning.

Fixes #XX (if there's no associated Github issue, delete this line)

Delete this line and everything after before submitting your PR

How to get your PR merged quickly

  • Read my guide, "How to Make Your Code Reviewer Fall in Love with You," to understand how to contribute effectively to an open source project.
  • Give a clear, one-line title to your PR.
    • Good: Fix dropped keystrokes on Firefox
    • Bad: Fix issue
  • If your PR is not ready for review, mark it as "draft."
  • Rebase your changes onto the latest master commit so that there are no merge conflicts.
  • Your PR must pass build checks in CI before it will be considered for merge.
    • You'll see a green checkmark or red X next to your PR depending on whether your build passed or failed.
    • You are responsible for fixing formatting and tests to ensure that your code passes build checks in CI.

I try to review all PRs within one business day. If you've been waiting longer than this, feel free to comment on the PR to verify that it's on my radar.