Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow regexes or minimatch-like sytax to work in ignores #124

Open
AndreaPontrandolfo opened this issue Sep 30, 2024 · 7 comments
Open

Allow regexes or minimatch-like sytax to work in ignores #124

AndreaPontrandolfo opened this issue Sep 30, 2024 · 7 comments

Comments

@AndreaPontrandolfo
Copy link

It would be nice if the syntax for the various ignores options could be widened with regexes or minimatch-like syntax.

@jeffijoe
Copy link
Owner

Regex and minimatch are CVE nightmares, if we do this it would be basic starts-with foo* and ends with *foo.

@lishaduck
Copy link
Contributor

Does typesync support JS config files? Couldn't you just use native regexes? If there's an issue it'd be your (configurer's) own fault and it doesn't pull in a library for matching.

@jeffijoe
Copy link
Owner

jeffijoe commented Oct 1, 2024

It does, but it feels weird to force users to use JS config files to enable a particular feature.

@lishaduck
Copy link
Contributor

lishaduck commented Oct 24, 2024

Oh, forgot this. Added globs for ignored projects in #126.
Is it ok if it's inconsistent?

EDIT: We already depend on minimatch anyway. tinyglobby doesn't though, if you'd prefer a PR in that direction.

@jeffijoe
Copy link
Owner

We already depend on glob which as you said depends on `minimatch. #126 is fine.

@jeffijoe
Copy link
Owner

jeffijoe commented Dec 2, 2024

@lishaduck can we close this now?

@lishaduck
Copy link
Contributor

We only support globs for workspaces, but not for dependencies. @AndreaPontrandolfo, I assume you wanted both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants