-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow regexes or minimatch-like sytax to work in ignores #124
Comments
Regex and minimatch are CVE nightmares, if we do this it would be basic starts-with |
Does typesync support JS config files? Couldn't you just use native regexes? If there's an issue it'd be your (configurer's) own fault and it doesn't pull in a library for matching. |
It does, but it feels weird to force users to use JS config files to enable a particular feature. |
Oh, forgot this. Added globs for ignored projects in #126. EDIT: We already depend on minimatch anyway. tinyglobby doesn't though, if you'd prefer a PR in that direction. |
We already depend on |
@lishaduck can we close this now? |
We only support globs for workspaces, but not for dependencies. @AndreaPontrandolfo, I assume you wanted both? |
It would be nice if the syntax for the various ignores options could be widened with regexes or minimatch-like syntax.
The text was updated successfully, but these errors were encountered: