Add Unit Tests

[jeltedeproft]

In order to smooth out future development, Unit Tests will become a necessity.
At the moment we barely have any.

[NyorJa]

what unit test framework are we gonna use? is it mockito? if yes then I am happy to take this

[jeltedeproft]

@NyorJa no decision on that yet, more than happy to use Mockito. Can we combine that with Junit? I'll add the Mockito dependency to the Gradle build file.

[NyorJa]

Yes please and what package do I need to cover?

…

On Thu, 10 Oct 2019, 11:51 PM jelte de proft, ***@***.***> wrote: @NyorJa <https://github.com/NyorJa> no decision on that yet, more than happy to use Mockito. Can we combine that with Junit? I'll add the Mockito dependency to the Gradle build file. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10?email_source=notifications&email_token=AB6FLERI4EQA7WQ4XGNN4QDQN5FQ3A5CNFSM4I6RXYE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA43ATI#issuecomment-540651597>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB6FLEV5L436KFXR2EVCIFLQN5FQ3ANCNFSM4I6RXYEQ> .

[jeltedeproft]

@NyorJa sorry for the late reply, up to you, whatever you think is most fun, eventually all of them kinda need tests. I guess the Screen package is the most important one, but also very graphic so maybe hard to test.

I tried adding the Mockito dependency, but when I then tested with a random Mockito class, It said that it couldnt find the import :/ idk what im doing wrong

[jeltedeproft]

@NyorJa Mockito should now be working, I was confused because I added a class to test if the import works, but I used testCompile in gradle build file, so it doesn't work unless its in the test package.

[jeltedeproft]

@NyorJa hey, The Mockito is working now, qre you still interested in adding Unit Tests?

[NyorJa]

HI jetle, It is still on progress.

…

On Mon, Oct 14, 2019 at 8:06 PM jelte de proft ***@***.***> wrote: @NyorJa <https://github.com/NyorJa> hey, The Mockito is working now, qre you still interested in adding Unit Tests? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10?email_source=notifications&email_token=AB6FLEUHI4FX36LRM2ZV73DQORODLA5CNFSM4I6RXYE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBEL3IA#issuecomment-541638048>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB6FLEQGHU63SYUUFYDAKYDQORODLANCNFSM4I6RXYEQ> .

[jeltedeproft]

@NyorJa ah I'm sorry. If something needs clarification, I'm here :)

[alvin-muniz]

Hi! I am eager to help with this project. I'm learning JUnit and think this would be a great opportunity for me to get some experience.

Are you available if I have any questions on how to set up some of the tests?

[jeltedeproft]

@alvin-muniz Hey Alvin, yeah sure , you can always email me at jeltedeproft_8@hormail.com
Or you can join our discord.

I have to admit , since starting my new job I am way less active in developing, but I am definitely available to answer your questions.

[NyorJa]

Hi @jeltedeproft,

Please see my pull request. Its an example of unit test for Mockito. I know there are other better framework in unit testing in Android. I also arrange the packages.

[jeltedeproft]

@alvin-muniz merged it 👍