Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of whitelist with allowlist/clearlist and blacklist with denylist/blocklist #273

Open
hvongsachang opened this issue Feb 16, 2022 · 2 comments

Comments

@hvongsachang
Copy link

In a similar fashion to this issue: rails/rails#33677, it would be nice if vulture could replace use of whitelist with allowlist/clearlist and blacklist with denylist/blocklist for better terminology. If not replace, then perhaps add support to detect allowlist and blocklist.

@jendrikseipp
Copy link
Owner

I think we can even find a more specific name for the modules that fake code usage. I like the name "fake module" and would be happy to review a pull request that changes

  • "whitelist" to "fake module" in text,
  • "whitelist" to "fake_module" in code,
  • and "--make-whitelist" to "--make-fake-module".

@SvenWarnke
Copy link

I am not sure if --make-fake-module is as intuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants