From 5511bad40338142dc3205d9b2e4e12c9ce390a99 Mon Sep 17 00:00:00 2001
From: Alexander Straube <alexander.straube@gmail.com>
Date: Thu, 9 Feb 2023 13:19:55 +0100
Subject: [PATCH] Fix for javadoc issues (#216)

* removed maven.javadoc.skip=true
* fix javadoc errors
---
 Jenkinsfile                                                     | 2 +-
 .../plugins/performance/constraints/AbstractConstraint.java     | 1 -
 .../plugins/performance/parsers/PerformanceReportParser.java    | 1 -
 .../hudson/plugins/performance/parsers/WrkSummarizerParser.java | 2 --
 .../hudson/plugins/performance/reports/ConstraintReport.java    | 1 -
 5 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/Jenkinsfile b/Jenkinsfile
index 013d3d62..2b6778d1 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -13,7 +13,7 @@ node('linux-amd64') {
             sh 'pip install --upgrade pip'
             sh 'pip install -r requirements.txt'
             
-            def args = ['clean', 'install', '-Dmaven.javadoc.skip=true', '-Dset.changelist']
+            def args = ['clean', 'install', '-Dset.changelist']
             infra.runMaven(args, 11)
         }
     }
diff --git a/src/main/java/hudson/plugins/performance/constraints/AbstractConstraint.java b/src/main/java/hudson/plugins/performance/constraints/AbstractConstraint.java
index 3d91612b..4d07e410 100644
--- a/src/main/java/hudson/plugins/performance/constraints/AbstractConstraint.java
+++ b/src/main/java/hudson/plugins/performance/constraints/AbstractConstraint.java
@@ -165,7 +165,6 @@ protected double checkMetredValueforPerfReport(Metric meteredValue, PerformanceR
      *
      * @param builds all stored jenkins builds
      * @throws AbortException if a parameter in the UI is not processable
-     * @throws ParseException if a timeframe string in the UI is not processable
      */
     protected void checkForDefectiveParams(List<? extends Run<?, ?>> builds) throws AbortException {
         boolean found = false;
diff --git a/src/main/java/hudson/plugins/performance/parsers/PerformanceReportParser.java b/src/main/java/hudson/plugins/performance/parsers/PerformanceReportParser.java
index 0bbef4a6..a1d03408 100644
--- a/src/main/java/hudson/plugins/performance/parsers/PerformanceReportParser.java
+++ b/src/main/java/hudson/plugins/performance/parsers/PerformanceReportParser.java
@@ -19,7 +19,6 @@
  * is persisted with {@link PerformancePublisher} into the project
  * configuration.
  * <p>
- * <p>
  * Subtypes can define additional parser-specific parameters as instance fields.
  *
  * @author Kohsuke Kawaguchi
diff --git a/src/main/java/hudson/plugins/performance/parsers/WrkSummarizerParser.java b/src/main/java/hudson/plugins/performance/parsers/WrkSummarizerParser.java
index ede69362..9241c424 100644
--- a/src/main/java/hudson/plugins/performance/parsers/WrkSummarizerParser.java
+++ b/src/main/java/hudson/plugins/performance/parsers/WrkSummarizerParser.java
@@ -15,7 +15,6 @@
 /**
  * Parser for wrk (https://github.com/wg/wrk)
  * <p>
- * <p>
  * Note that Wrk does not produce request-level data, and can only be processed
  * in it's summarized form (unless extended to do otherwise).
  *
@@ -178,7 +177,6 @@ PerformanceReport parse(File reportFile) throws Exception {
      * Given a time string (eg: 0ms, 1m, 2s, 3h, etc.) parse and yield the time in
      * a specified time unit (millisecond, second, minute, hour)
      * <p>
-     * <p>
      * If no result can be returned, a 0 value will result and any errors
      * encountered will be logged.
      *
diff --git a/src/main/java/hudson/plugins/performance/reports/ConstraintReport.java b/src/main/java/hudson/plugins/performance/reports/ConstraintReport.java
index 2ba9e804..021f5530 100644
--- a/src/main/java/hudson/plugins/performance/reports/ConstraintReport.java
+++ b/src/main/java/hudson/plugins/performance/reports/ConstraintReport.java
@@ -307,7 +307,6 @@ private String createJunitReport(ArrayList<ConstraintEvaluation> ceList) {
      * persistConstraintLog == true
      *
      * @throws IOException
-     * @throws InterruptedException
      */
     public void writeResultsToFile() throws IOException {
         performanceLog = new File(newBuild.getRootDir() + File.separator + "performance-results" + File.separator + "performance.log");