Remove static array creation in isStatusMessage()

jenkinsci · Oct 5, 2024 · 2b9a912 · 2b9a912
1 parent 4add480
commit 2b9a912
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java b/src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java
@@ -59,6 +59,7 @@ public class StashRepository {
       "\\[\\*BuildFinished\\* \\*\\*%s\\*\\*\\] ([0-9a-fA-F]+) into ([0-9a-fA-F]+)";
   private static final String BUILD_CANCEL_REGEX =
       "\\[\\*BuildCanceled\\* \\*\\*%s\\*\\*\\] ([0-9a-fA-F]+) into ([0-9a-fA-F]+)";
+  private static final String[] BUILD_REGEXES = {BUILD_START_REGEX, BUILD_FINISH_REGEX, BUILD_CANCEL_REGEX};
 
   private static final String BUILD_FINISH_SENTENCE =
       BUILD_FINISH_MARKER + " %n%n **[%s](%s)** - Build *&#x0023;%d* which took *%s*";
@@ -147,8 +148,7 @@ private boolean shouldSkip(StashPullRequestResponseValue pullRequest) {
 
   private boolean isStatusMessage(String content) {
     String escapedBuildName = Pattern.quote(job.getDisplayName());
-    String[] patterns = {BUILD_START_REGEX, BUILD_FINISH_REGEX, BUILD_CANCEL_REGEX};
-    for (String pattern : patterns) {
+    for (String pattern : BUILD_REGEXES) {
       String buildStatusMessage = String.format(pattern, escapedBuildName);
       Matcher matcher =
           Pattern.compile(buildStatusMessage, Pattern.CASE_INSENSITIVE).matcher(content);