Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

according to location-based example in website, It does not work. #825

Open
jiajia-tao opened this issue Jun 8, 2023 · 4 comments
Open

Comments

@jiajia-tao
Copy link

according to location-based example code in website, It does not work.

I think the aframe-ar-nft.js has some wrong , then I see the aframe-ar-new-location-only.js in ar.js-master/aframe/build ,so t decide to use this file .finally ,it does work .

image

@jiajia-tao
Copy link
Author

Because I do not understand basic principle,please tell me the differences between aframe-ar-nft.js and aframe-ar-new-location-only.js.
THANKS.

@turbotimon
Copy link

turbotimon commented Jun 23, 2023

In your code your pointing to a local source ./js/aframe-ar.js do you have the script local?

According to the github readme, both should be valid for location based AR:

AR.js with Image Tracking + Location Based AR (AFRAME):
https://raw.githack.com/AR-js-org/AR.js/master/aframe/build/aframe-ar-nft.js
AR.js with Marker Tracking + Location Based AR (AFRAME):
https://raw.githack.com/AR-js-org/AR.js/master/aframe/build/aframe-ar.js

And in their location based examples, they use both, aframe-ar.js here and aframe-ar-nfr.js here

However, they never mentioning the aframe-ar-location-only.js and aframe-ar-new-location-only.js ... 😕

I would be nice if a maintainer could clarify if there is a difference between the four and if there is a recommendation which one to use for location based (only) 🙏

@turbotimon
Copy link

turbotimon commented Jun 23, 2023

Here in the docs, they talking about three different components
gps-new-entity-place, gps-projected-entity-place and gps-entity-place

However, it is unclear to me, which does work with which script. For example gps-new-entity-place seems not to work with aframe-ar-new-location-only.js due to several TypeErrors. Despite both have the word "new" in it..

Btw, i couldn't get any example working so far. If anybody has a working example, please post it here

@nickw1
Copy link

nickw1 commented Oct 26, 2024

@turbotimon sorry I have only just seen this issue, because this is an old (no longer maintained) repository of AR.js.

The current repo is

https://github.com/AR-js-org/AR.js

so please file an issue there.

gps-new-entity-place should indeed work with aframe-ar-new-location-only, so I'm not sure why it isn't in your case. If you still have problems feel free to send me the code.

However, also please note location based AR is now moving to its own repository, independent of marker/NFT:

https://github.com/AR-js-org/locar.js

One of the reasons behind this is simplification, to have a single, unambiguous repository and code base to work with location-based AR. Another reason is easier bug fixing.

The majority of future work will be on this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants