Consider moving CompilationDatabase flag preparation logic into the server #6
Comments
jerrymarino
added a commit
that referenced
this issue
Jun 1, 2017
In hindsight, it was a shitty decision to put flag prep in the client ( Probably a whisky driven design decision ) Revert this mistake. The CompilationDatabase should be an input to Swift services and tools ( like how this works in clang ). Now the client simply prepares a CompilationDatabase, and sends us commands from that. We need to process flags for diagnostics and it is more reasonable to have all of this flag logic happen in 1 place, and have clear definitions of what the server accepts as input for these flags. resolves #6 There should be a PR to YCMD as well ( or just merge into ycm-core/ycmd#487 ) TODO: Additionally consider making the flags accept a string instead of an array. It is insane to convert the string to an array on the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
compile_commands.jsonhas records whichcommand's are compiler invocations for compilation.For diagnostics and completion, we need to transform these invocations to the correct value for various semantic tasks.
Currently, this ability is implemented in the
YCMDclient. Consider moving this to the server to do less work on the client. This makes it easier to write clients.The text was updated successfully, but these errors were encountered: