Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image updates and versioning #600

Open
Guiorgy opened this issue Nov 25, 2024 · 2 comments
Open

Docker image updates and versioning #600

Guiorgy opened this issue Nov 25, 2024 · 2 comments

Comments

@Guiorgy
Copy link

Guiorgy commented Nov 25, 2024

Though there have been a few releases on github lately, the latest tag on DockerHub still sits at Last pushed 3 years ago by lazyteam. What is the update plan for the Docker image?

Also, I tried to determine which version/commit the Docker image contains, however the two methods below both failed:

$ docker exec -it LazyDocker /bin/lazydocker --version
Version:
Date:
BuildSource: Docker
Commit:
OS: linux
Arch: amd64
$ docker inspect lazyteam/lazydocker
...
            "Labels": {
                "org.opencontainers.image.authors": "jessedduffield@gmail.com",
                "org.opencontainers.image.created": "",
                "org.opencontainers.image.description": "The lazier way to manage everything docker",
                "org.opencontainers.image.documentation": "https://github.com/jesseduffield/lazydocker",
                "org.opencontainers.image.revision": "",
                "org.opencontainers.image.source": "https://github.com/jesseduffield/lazydocker",
                "org.opencontainers.image.title": "lazydocker",
                "org.opencontainers.image.url": "https://github.com/jesseduffield/lazydocker",
                "org.opencontainers.image.version": ""
            }
...

In both cases, the version and date fields were empty. Is this intentional? Is there another way to query the version of lazydocker?

@MycatQieZi
Copy link

I checked the Dockerfile and found that the version is passed as a custom parameter. Perhaps when building the image, you need to specify the version information for the current image being built using docker build --build-arg

@Guiorgy
Copy link
Author

Guiorgy commented Jan 14, 2025

@MycatQieZi The README has the following in the instructions for building a docker image manually: ... --build-arg VERSION=`git describe --abbrev=0 --tag` .... This does result in the following (PS. date still seems broken?):

docker exec -it LazyDocker /bin/lazydocker --version
Version: v0.24.1
Date:
BuildSource: Docker
Commit: bedde4a
OS: linux
Arch: amd64

However, this wasn't the point. The README also makes it seem that a docker image should only be built if you are considering contributing, otherwise you should use the prebuilt image from the Docker Hub:

Run the container:

[Instructions on running the container with the image from Docker Hub]

For development, you can build the image using:

[Instructions on building an image yourself]

However, the image on Docker Hub is extremely old, and that image hasn't had the version/date arguments properly passed when built. Was this a mistake, or will all official images not have those fields filled? This is the main point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants