Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to apache.hc.core5 for Spring-Boot-3 #374

Open
MarcAffolter opened this issue May 2, 2023 · 1 comment
Open

Migration to apache.hc.core5 for Spring-Boot-3 #374

MarcAffolter opened this issue May 2, 2023 · 1 comment

Comments

@MarcAffolter
Copy link

Hi together

The Problem
Support for Apache HttpClient has been removed in Spring Framework 6.0, immediately replaced by org.apache.httpcomponents.client5:httpclient5 (note: this dependency has a different groupId), and so for Spring-Boot-3.

artifactory-client-java with version 2.13.1 seems still only to support the old apache client version: org.apache.http
For example while creating an ArtifactoryClient with the ArtifactoryClientBuilder.create() method, the method .addInterceptor()accepts an HttpRequestInterceptor which is org.apache.http and would newly be org.apache.hc.core5.http

Thank you for looking into this.

@eyalbe4
Copy link
Contributor

eyalbe4 commented May 2, 2023

Thanks for reporting this @MarcAffolter.
We would happily accept this upgrade through a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants