Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmet peer dependency with Webpack 4 #6

Open
nickensoul opened this issue Jan 29, 2019 · 2 comments
Open

Unmet peer dependency with Webpack 4 #6

nickensoul opened this issue Jan 29, 2019 · 2 comments

Comments

@nickensoul
Copy link

In my case, loader works fine with Webpack 4, but throws unmet peer dep.
Console output using command npm list -depth=0:

├── ...
├── UNMET PEER DEPENDENCY webpack@4.28.1
npm ERR! peer dep missing: webpack@^3 || ^2 || ^2.2.0-rc.0 || ^2.1.0-beta || ^1.12.6, required by sass-extract-loader@1.1.0

My suggestion is to add Webpack 4 version to peers, if loader works as expected with this version.
Thanks.

@kenime
Copy link

kenime commented Sep 9, 2019

I am happy to create a PR for this, but since webpack 4 requires node version >= 6.11.5 (current package requirement is >=4), technically this is a breaking change.

@jgranstrom need your advice in whether to bump a major version or minor version.

@DanielSchaffer
Copy link

@kenime I'm obviously not the maintainer, but I'd recommend a major version - that way folks on older versions of node using a ^ semver pattern don't get hosed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants