Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting needs to be a PR check #22

Closed
jhatler opened this issue Dec 22, 2023 · 0 comments · Fixed by #26 or #28
Closed

Linting needs to be a PR check #22

jhatler opened this issue Dec 22, 2023 · 0 comments · Fixed by #26 or #28

Comments

@jhatler
Copy link
Owner

jhatler commented Dec 22, 2023

The GitHub super-linter project should be used.

A script should be created which allows the linting to be run locally.

jhatler added a commit that referenced this issue Dec 22, 2023
This adds a GitHub workflow that runs super-linter on all PRs. It
configures super-linter using the super-linter.env file which sets env
vars for the linter. It also adds a script to run the linter locally
using the same env vars. A VSCode task was added which runs the script.

Finally, a .editorconfig file was added to ensure the linting and editor
settings are the same.

Refs: #22
Signed-off-by: Jaremy Hatler <hatler.jaremy@gmail.com>
@jhatler jhatler linked a pull request Dec 22, 2023 that will close this issue
jhatler added a commit that referenced this issue Dec 22, 2023
This adds a GitHub workflow that runs super-linter on all PRs. It
configures super-linter using the super-linter.env file which sets env
vars for the linter. It also adds a script to run the linter locally
using the same env vars. A VSCode task was added which runs the script.

Finally, a .editorconfig file was added to ensure the linting and editor
settings are the same.

Refs: #22
Signed-off-by: Jaremy Hatler <hatler.jaremy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant