Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'split' of undefined #1

Open
Jey-Cee opened this issue Jan 7, 2020 · 2 comments
Open

Cannot read property 'split' of undefined #1

Jey-Cee opened this issue Jan 7, 2020 · 2 comments
Labels

Comments

@Jey-Cee
Copy link

Jey-Cee commented Jan 7, 2020

I saw the message in title, several times, but cant reproduce it.
After a little research i came to ssdp.js line 104 & 105 and changed it, see below, since that there wasnt an error and everything works.

protocol: protocol ? protocol.split( '/' ).shift().toLowerCase() : '',
version: protocol ? protocol.split( '/' ).pop() : '',

@jhermsmeier jhermsmeier added the bug label Jan 7, 2020
@jhermsmeier
Copy link
Owner

Seems that would indicate that there's something wrong with the incoming message, which this module doesn't handle very well at the moment.

Is there a particular context this tends to happens in? I'd suggest logging the incoming message if there's no protocol, to check what's going on there. If you come across a message that triggers it, it'd be helpful if you could post it here!

@Jey-Cee
Copy link
Author

Jey-Cee commented Jan 7, 2020

Thats the problem couldnt find a context. On one day there was this problem, on the other day i would check whats the problem but could not see.
I will try to catch the message which is causing the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants