Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should mention --no-ff in Pull Request section (integrate 10.iv to 4) #23

Open
Jaykul opened this issue Nov 21, 2018 · 0 comments
Open

Comments

@Jaykul
Copy link

Jaykul commented Nov 21, 2018

There is a sort-of footnote in the git best practices section:

vi. It is RECOMMENDED that all branches be merged using "git merge --no-ff". This makes sure the reference to the original branch is kept in the commits, allows one to revert a merge by reverting a single merge commit, and creates a merge commit to mark the integration of the branch with master.

I think this should be moved/copied to section 4 where you're initially discussing merging pull requests and change branches (just as the --force-with-lease is mentioned when rebasing is mentioned). My suggestion would be to insert 10-vi into 4 as a new v (pushing the current v to vi).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant