Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible collaboration with user nimanshr #2

Open
jkmacc-LANL opened this issue Jul 2, 2018 · 3 comments
Open

Possible collaboration with user nimanshr #2

jkmacc-LANL opened this issue Jul 2, 2018 · 3 comments

Comments

@jkmacc-LANL
Copy link
Owner

jkmacc-LANL commented Jul 2, 2018

A quick search turned up another Python project implementing the PEIP library and examples in Python. It may be worth collaborating with @nimanshr.

  • They are using Python 2.7 (end-of-life in 17 months), I'm using Python 3.5+ .
  • Their examples are Python scripts, I'm using Jupyter notebooks.
  • They've made a lot of progress on the PEIP library, and implemented many chapter 3, 4, 8, and 11 examples.
@nimanzik
Copy link

Hi Jonathan,
I'm so glad to see that we have the same interest in implementing PEIP examples and functions in Python.
I started this as a personal interest project last year, and always have been thinking that it would be great and helpful if the examples and tools can be implemented in Python.
Regarding the points you mentioned:
- Python 3 compatibility should not be difficult. I'll take care of it.
- Preparing the examples in Jupyther notebooks is almost easy. It can be done quickly.

I am open to contribute in this project. I am sure it's gonna be helpful for the readers.
We should make a plan to proceed.

@jkmacc-LANL
Copy link
Owner Author

Hi Nima. I'm glad to hear that you're willing to work together on this. You've already done quite a bit of work! Let's definitely combine efforts, as I think we have a similar vision.

  • An installable PEIP library.
  • NumPy-style docstrings.
  • Tests.

If you're willing to convert to Python 3 and Jupyter notebooks, I will work on the Examples you haven't done yet and start using peiplib. What do you think?

@jkmacc-LANL
Copy link
Owner Author

@nimanzik Have you changed the name if this peip project, or removed it? I'd love to continue to look at your repo. Would you be willing to put it back, even temporarily to allow me to fork it, so I could occasionally make reference to it? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants