Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows pathnames. #36

Open
pinuke opened this issue Oct 7, 2016 · 2 comments
Open

Windows pathnames. #36

pinuke opened this issue Oct 7, 2016 · 2 comments

Comments

@pinuke
Copy link

pinuke commented Oct 7, 2016

It would be a good idea to remind people to not use the Windows pathname structure when pulling the issues. otherwise this error is produced:

offline-issues JavaScriptAI\regex.objectified (for example, produces the below error):

C:\Users\******\AppData\Roaming\npm\node_modules\offline-issues\src\index.js:32
      if (userAndRepo[1].indexOf('#') >= 0) {
                        ^

TypeError: Cannot read property 'indexOf' of undefined
    at C:\Users\******\AppData\Roaming\npm\node_modules\offline-issues\src\index.js:32:25
    at Array.forEach (native)
    at parseRepo (C:\Users\******\AppData\Roaming\npm\node_modules\offline-issues\src\index.js:27:15)
    at module.exports (C:\Users\******\AppData\Roaming\npm\node_modules\offline-issues\src\index.js:22:3)
    at C:\Users\******\AppData\Roaming\npm\node_modules\offline-issues\src\cli.js:35:3
    at afterConfigRead (C:\Users\Nick\AppData\Roaming\npm\node_modules\offline-issues\node_modules\ghauth\ghauth.js:142:14)
    at C:\Users\******\AppData\Roaming\npm\node_modules\offline-issues\node_modules\ghauth\node_modules\application-config\index.js:22:5
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:380:3)

I would remind Windows users not to use the "" and instead use the "/"

(offline-issues JavaScriptAI\regex.objectified as opposed to offline-issues JavaScriptAI/regex.objectified)

@pinuke
Copy link
Author

pinuke commented Oct 7, 2016

It's an easy fix. Just console.log a warning on line 30 if using the "", and change the "" to a "/"

@pinuke
Copy link
Author

pinuke commented Oct 7, 2016

Will provide my own fix later, if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant