Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOM should only be edited via Renderer2 #32

Open
jmcker opened this issue Apr 4, 2019 · 0 comments
Open

DOM should only be edited via Renderer2 #32

jmcker opened this issue Apr 4, 2019 · 0 comments
Labels
angular
Milestone
Angular Conversion

Comments

@jmcker
Copy link
Owner

jmcker commented Apr 4, 2019

DOM should really only be touched via Renderer2. I'm not sure this is important since there is no plan to render server side, but it might still be good to follow best practice.

Worst offenders:

  • shared/html-media.component.ts
@jmcker jmcker added this to the Angular Conversion milestone Apr 4, 2019
@jmcker jmcker added the angular label Apr 4, 2019
@jmcker jmcker changed the title DOM should only be edited via Rederer2 DOM should only be edited via Renderer2 Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
angular
Projects
None yet
Milestone
Angular Conversion
Development

No branches or pull requests
1 participant
@jmcker