Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files are overwritten on the second pass #128

Open
gauvinalexandre opened this issue Oct 27, 2023 · 1 comment
Open

Files are overwritten on the second pass #128

gauvinalexandre opened this issue Oct 27, 2023 · 1 comment
Assignees
Labels

Comments

@gauvinalexandre
Copy link

gauvinalexandre commented Oct 27, 2023

When running bidskit for the second time using the following command,

bidskit -d {data_dir} -subj {subjects_to_convert} -sess {sessions_to_convert}

the file participants.json and dataset_description.json are overwritten, even if I've set them myself. Then, bids-validator obviously complains as the columns of the participants.tsv are not described and dataset_description.json containing empty fields...

Should'nt bidskit detect if pre-existing files exist before overwriting them?

@gauvinalexandre gauvinalexandre changed the title participants.json is overwritten on the second pass Files are overwritten on the second pass Oct 27, 2023
@jmtyszka
Copy link
Owner

Good catch and yes, bidskit shouldn't be overwriting user edited files like these top-level JSONs. Working on a fix now.

@jmtyszka jmtyszka added the bug label Oct 27, 2023
@jmtyszka jmtyszka self-assigned this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants