Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Decending X-Axis changes axis titles and data, but not tooltips/hover #490

Open
jberry opened this issue Dec 14, 2021 · 5 comments · Fixed by #497
Open

[BUG]: Decending X-Axis changes axis titles and data, but not tooltips/hover #490

jberry opened this issue Dec 14, 2021 · 5 comments · Fixed by #497
Labels
bug Something isn't working
Milestone

Comments

@jberry
Copy link

jberry commented Dec 14, 2021

Describe the bug
When you select "Descending x-axis", the data and axis titles rotate, but when you hover-over the data, it's showing the non-flipped-data for rotation

Expected behavior
I expect the tooltips/hover to be correct

Screenshots
xaxis1
xaxis2

Firmware and Version
Bed Visualizer Settings version 1.1.0

@jneilliii jneilliii added the bug Something isn't working label Dec 14, 2021
@jneilliii
Copy link
Owner

Thank you for your report. When I get some time I'll investigate this further. I've never really been happy with how this table works (was contributed by someone else).

@jberry
Copy link
Author

jberry commented Dec 14, 2021

Yeah, I'm not overly fond of it, especially when you start rotating the graphic and the table is static, and you start adjusting things wrong (totally user fault: mine). But it'd be nice if the graphic at least loaded in the same orientation as the table's data layout (i.e. front edge in my graphic should load as 315:340, not 0:0, when the table is flipped via checkboxes/etc.)

I haven't checked out the project yet to poke around myself, but if I get time I'll see if I can as well

@jneilliii jneilliii added this to the 1.1.2 milestone Dec 31, 2021
@jneilliii
Copy link
Owner

rather than actually fixing this I'm just going to take the hover tooltip out completely. It just doesn't seem to be beneficial and taking it out should actually improve processing time.

jneilliii added a commit that referenced this issue Jan 1, 2022
add option for showing mesh data on tab, #496
remove tooltip hover on tables, #490
@jneilliii jneilliii added the solved workaround documented or fix applied label Jan 1, 2022
@jneilliii jneilliii mentioned this issue Jan 1, 2022
jneilliii added a commit that referenced this issue Jan 1, 2022
* add ability to configure graph height in visualization settings, #462
* add min, max, and variance values of graphed mesh, #286
* add OctoDash support, create Custom Action with `[!WEB]http://127.0.0.1:5000/plugin/bedlevelvisualizer/bedlevelvisualizer` as the command.
* adjust the tables for better theme support, #479
* add option for showing mesh data on tab, #496
* remove tooltip hover on tables, #490
* add Prusa adjustment values to graph (still needs verification), #242
* add appearance > title setting to automatically downloaded snapshots, #494
* update docs and screenshots, #335, #358, #468
@jberry
Copy link
Author

jberry commented Jan 3, 2022

This did not resolve the data issue of the right chart, the data is still flipped. As you can see in my screenshot below, mousing over the blue 50 shows the data for the red 3:
image
And here's the opposite, mousing over the red 3 shows the data for the blue 50:
image

@jneilliii jneilliii reopened this Jan 3, 2022
@jneilliii
Copy link
Owner

Sorry I wasn't paying attention. I thought the issue that the arrow on the mouse pop-over was incorrect, not the actual calculated turns.

@jneilliii jneilliii modified the milestones: 1.1.1, 1.1.2 Jan 30, 2022
@jneilliii jneilliii removed the solved workaround documented or fix applied label Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants