Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: The custom command icon picker does not have the search function enabled #665

Open
sharky98 opened this issue Jul 7, 2024 · 2 comments
Labels
enhancement New feature or request solved workaround documented or fix applied
Milestone

Comments

@sharky98
Copy link

sharky98 commented Jul 7, 2024

Describe the bug
When using the icon picker, there is no search function, even though there should be according to the jinja template.

<button type="button" class="icp icp-dd btn dropdown-toggle" data-selected="fa-car" data-toggle="dropdown" aria-expanded="false" data-bind="iconpicker: icon,iconpickerOptions: {searchInFooter: true, hideOnSelect: true, collision: true}">

Expected behavior
Search function active.

This may be due to the footer not being shown by default? IE, not having showFooter: true?

Screenshots
image

Firmware and Version
BedLevelVisualizer v1.1.1

@jneilliii
Copy link
Owner

You're completely right. The options need to include showFooter: true for the search to show, however that introduces another bug, where when you click in the input box, it instantly closes the window and you can't type. I think I was actually using the searchInFooter and not showing the footer to hide the input box because of this.

However, I was able to figure out I could define the container property, and tweak the popover template to get it to show in the middle of the tab with search functionality.

image

I'll add this change and release a new rc version with it.

@jneilliii jneilliii added enhancement New feature or request solved workaround documented or fix applied labels Jul 7, 2024
@jneilliii jneilliii added this to the 1.1.2 milestone Jul 7, 2024
@jneilliii
Copy link
Owner

1.1.2rc11 released with the above commit. You can change the plugin's release channel in Software Update settings to Release Candidate and upgrade when prompted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request solved workaround documented or fix applied
Projects
None yet
Development

No branches or pull requests

2 participants