New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements #6

Open

albertogasparin wants to merge 4 commits into joelambert:master from albertogasparin:master

albertogasparin commented Jun 29, 2012

Hi Joe,
I've tweaked your code to better fit my needs, but I think my changes could interest you.

I've fixed a small lag that sometimes occurs on the first scroll (because startTopScroll was undefined)
I've changed the method to get the height (from offsetHeight to clientHeight).
If the element has a border, your scroll function will do it wrong.
I've added the ability to prevent the scroll if the element is smaller than the visible area.
It is useful if you want a correct behavior in a WebView app (preventing outer page scroll).

albertogasparin added 4 commits

June 29, 2012 13:55


          Fixed possible initial lag or unrensponsiveness

696f11d


          Changed height calc in order to ignore borders

a541dd7


          Prevent page scroll where the content is smaller than visible area

d6200f0


          Fixed wrong event binding

7db868a

Touchstart will prevent input focus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet