Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

classmethod build_module_as_str is untested? #45

Closed
cbm755 opened this issue Feb 27, 2023 · 2 comments
Closed

classmethod build_module_as_str is untested? #45

cbm755 opened this issue Feb 27, 2023 · 2 comments
Milestone
v0.2

Comments

@cbm755
Copy link
Collaborator

cbm755 commented Feb 27, 2023

AFAICT, the actual command line tool doesn't run build_module_as_str. Nor does pytest.

(I tried putting an assert False in there and nothing has triggered it yet).

In #41, I'm adding build_module_as_yaml_str, which is similarly untested.

I guess the command line tool should run these classmethods intead, except they are designed to return strings and the command-line tool is based on streams.
@cbm755 cbm755 mentioned this issue Feb 27, 2023
Merged
9 tasks
@johannesjh
Copy link
Owner

Hi, thank you for your analysis. Yes, you are right... the commandline tool should use the classmethod instead of calling json.dump(build_module, output_stream, indent=4).

real-yfprojects added a commit to cbm755/req2flatpak that referenced this issue Mar 11, 2023
@real-yfprojects
Use FlatpakGenerator.build_module_as_[yaml_]str in main.
de6e865 
These methods implement formatting, so why duplicate that code. Fixes johannesjh#45.

* req2flatpak.py (main)
real-yfprojects added a commit to cbm755/req2flatpak that referenced this issue Mar 11, 2023
@real-yfprojects
Use FlatpakGenerator.build_module_as_[yaml_]str in main.
6d9303d 
These methods implement formatting, so why duplicate that code. Fixes johannesjh#45.

* req2flatpak.py (main)
@johannesjh
Copy link
Owner

Fixed in #41

@johannesjh johannesjh added this to the v0.2 milestone Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2
Development

No branches or pull requests
2 participants
@johannesjh @cbm755