Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features, merge possible? #25

Open
MrFly opened this issue Dec 9, 2013 · 43 comments
Open

Features, merge possible? #25

MrFly opened this issue Dec 9, 2013 · 43 comments

Comments

@MrFly
Copy link

MrFly commented Dec 9, 2013

Hi @john-tornblom,

first of all: thank you for this great app, this saved many times my day :-)

I downloaded the sources of TVHGuide two or three days ago and added some (useful?) features and I wanted to ask you if you eventually would merge this to your branch. I would like to have a way to contact you directly with a little more privacy. Do you see a way and have a little time to chat a little about this? I'm sorry, but due to the lack of sending mails over github (or I simply didn't find a way) I opened this ticket...

Regards,
Johann

@rsiebert
Copy link

Hi Johann, what features did you include? Did you check out my branch? (https://github.com/rsiebert/TVHGuide) It contains more features and an improved UI than this one. Unfortunately my branch is also not merged.
See the screenshots at https://github.com/rsiebert/TVHGuide

@john-tornblom
Copy link
Owner

Sorry for being idle, i'm very busy these days and have little time over for TVHGuide. Once I get some time over I'll see if I can integrate some new features.

@ghost
Copy link

ghost commented Dec 15, 2013

Hi Rsiebert
DId you check you version app TVHguide why cant play stream tv from TVHeadend. I describe you this problem in other issue. When i want play TV i have error.

Please update polish language in you app from this https://github.com/PiterEL/TVHGuide/commit/6a98632fd5074786bde7e938a2c330145a589309

@rsiebert
Copy link

rsiebert commented Jan 8, 2014

I fixed this in my local repository. I'm currently working on a program guide view. When its done I'll release a new version.

@ghost
Copy link

ghost commented Jan 8, 2014

Ok i am wait for info :) Please tell me on this thread.

@rsiebert
Copy link

@PiterEL I have released the new version 1.9.0. It contains some fixes and a new program guide. You can download it at http://rsiebert.github.io/TVHGuide/

@ghost
Copy link

ghost commented Jan 31, 2014

Ok i download And install your version 1.9.0 and still i have problem with play tv. I have error open file xxxxx(numbers). I use external player name BSplayer.

@rsiebert
Copy link

rsiebert commented Feb 3, 2014

Did you play with the available settings? For the media container use matroska, external player must be checked :-), transcode stream not checked. What error is shown? But the rest is working ok?

@ghost
Copy link

ghost commented Feb 3, 2014

OK works. But it working after setting the IP address tvheadend in Settings> Section Playback> Programs. There is also the Host Name section. Although CONNECTIONS I added the IP address of the server from TVHEADEND. Why is typing the host names in the joints and in the SETTINGS?

Is you app 1.9.0 can we download from Google Play Store in future ? It is very very good apps. Better than original TVHguide which we can donwload now from google play.

@rsiebert
Copy link

rsiebert commented Feb 3, 2014

Good to hear that it works. I'll remove the host settings and use the one from the connection. Makes indeed more sense.

@ghost
Copy link

ghost commented Feb 3, 2014

When did you relased new version with no host name in setting ?

@ghost
Copy link

ghost commented Feb 3, 2014

In STATUS when i recorded the programm i have a info: PROGRAM %S JEST NAGRYWANY... This is bug.... WHAT can display instead of %S ? My suggest is to add to SETTINGS opction to set language... not default set which is android language.

Update today my Polish translateed i send pull request.

@rsiebert
Copy link

rsiebert commented Feb 3, 2014

Thx for noticing the bug and updating the translation! I have fixed this and included your new translations. I'll make a new app version tomorrow.

@ghost
Copy link

ghost commented Feb 3, 2014

Why you apps is not published in Google Play ?

My suggest is to add to SETTINGS opction to set language... not default set which is android language.

Can you describe me how i can make from source apk to android ?

@rsiebert
Copy link

rsiebert commented Feb 3, 2014

Only he original author can publish an app under the name TVHGuide. So I need to use a different name like TVHGuide. I'll probably go for it.
I'll look into the language setting.
I'll use eclipse to develop and create a signed application. Just google "eclipse create signed android application" or something similar.

@ghost
Copy link

ghost commented Feb 3, 2014

I'll look into the language setting

I think about in menu the user can set language what you want.

@rsiebert
Copy link

rsiebert commented Feb 4, 2014

@PiterEL New version 1.9.1 is out

  • I have added the language selection in the settings menu.
  • The %S bug should be gone.
  • The server from the connection is now used for playback

There are some new strings to translate to polish. I guess its better you make a pull request against my repository not this one. You can also raise issues or features in my project so I can track them better.

@ghost
Copy link

ghost commented Feb 4, 2014

Hello
I installed version 1.9.1 and i see that you did not update some translation in polish...

@rsiebert
Copy link

rsiebert commented Feb 4, 2014

Hi, I have used the translation from #4. Maybe I missed something. But there are two more strings like pref_language ... to translate. If you make a PR then I'll add it.

@ghost
Copy link

ghost commented Feb 4, 2014

I will done this new translation today or tomorrow...

@ghost
Copy link

ghost commented Feb 4, 2014

Can i add Pull request to your git or git john...?

@rsiebert
Copy link

rsiebert commented Feb 4, 2014

Hi, its better to do it against my git project.

@ghost
Copy link

ghost commented Feb 4, 2014

OK i update translated to polish from english 1.9.1 It ist newest polish translated. You add this to you apps.

https://github.com/rsiebert/TVHGuide/pull/8

Change the file strings.xml to Polish language. I made the analogy to the English.

Add also https://github.com/rsiebert/TVHGuide/pull/7

When did you plan add this fix translated and released new version with new number ?

@ghost
Copy link

ghost commented Feb 5, 2014

When did you release version with my fix ?

@ghost
Copy link

ghost commented Feb 5, 2014

Hello Rsiebert. Can you help me how i can buil apk for android from git ?
I download and install Android SDK and Java JDE. After that i download on my local disk files from github. My folder with TVHGuide is location C:\Users\Piotrek\Documents\GitHub\TVHGuide

I open ECLIPS editor and import source from Git and then select local and select directory C:\Users\Piotrek\Documents\GitHub\TVHGuide

After i double clic on Android Manifest and select Export an unsigned APK and sign it manually

ANnd i have a problem error. Can you help me with this ?

Failed to export application
Command-line Error 1
Output:
C:\Users\Piotrek\Documents\GitHub\TVHGuide\bin\res\values-de\strings.xml:39: error: Resource entry delete_connection is already defined.
C:\Users\Piotrek\Documents\GitHub\TVHGuide\bin\res\values-de\strings.xml:38: Originally defined here.
C:\Users\Piotrek\Documents\GitHub\TVHGuide\bin\res\values\styles.xml:80: error: Error retrieving parent for item: No resource found that matches the given name 'Theme.AppCompat'.
C:\Users\Piotrek\Documents\GitHub\TVHGuide\bin\res\values\styles.xml:107: error: Error retrieving parent for item: No resource found that matches the given name 'Theme.AppCompat.Light'.

@rsiebert
Copy link

rsiebert commented Feb 7, 2014

@PiterEL I have released the new version.

@ghost
Copy link

ghost commented Feb 7, 2014

Can you Tell me how i can build apk on my computer. Please...

@rsiebert
Copy link

rsiebert commented Feb 7, 2014

You need to import the following two projects into eclipse

then add these two project to TVHGuide by going to "right click on TVHGuide -> properties -> android -> add library

@ghost
Copy link

ghost commented Feb 7, 2014

Where i can found seceond project ? In android SDK ?

First i know that import > git

@rsiebert
Copy link

rsiebert commented Feb 7, 2014

where your SDK is installed. Maybe C:\Programs\adt-bundle\sdk\extras\android\support\v7\appcompat or C:\Programs\android\sdk\extras\android\support\v7\appcompat

@ghost
Copy link

ghost commented Feb 7, 2014

:-( i dont understand. Can you describe me step by step please please :-(

@ghost
Copy link

ghost commented Feb 9, 2014

Please please help me step by step...:-(

@ghost
Copy link

ghost commented Feb 17, 2014

Rsiebert can you help me please...?

@rsiebert
Copy link

First you download the zip file from https://github.com/kolavar/android-support-v4-preferencefragment and unzip it anywhere. Then copy the extracted folder to the folder where TVHGuide is located.
The second project is located somewhere on your harddisk. Use the search function to search for a folder called "appcompat". The required files are located there. Check out http://developer.android.com/tools/support-library/setup.html and http://stackoverflow.com/questions/17903521/android-actionbar-how-to-add-supporting-library-v7-appcompat. Maybe this helps.

@ghost
Copy link

ghost commented Feb 20, 2014

OK i locate second project and i see tis but what i must do with this project ? First i know what but second i dont know.

@rsiebert
Copy link

Its the same procedure as for the first project. Import it into eclipse. Then add it as a library to TVHGuide.

@ghost
Copy link

ghost commented Mar 26, 2014

Rsiebert can you tell me how i must import TVHclient to Eclipse ? As ANDROID ? FILE>IMPORT>ANDROID>EXISTING ANDROID CODE INTO WORKSPACE and select directory with TVHclient download by GIHUB for windows ?

@ghost
Copy link

ghost commented Mar 26, 2014

ok i add but i have a bug...

http://www.fotosik.pl/pokaz_obrazek/ffb59f2b921f48c8.html

[2014-03-26 13:38:00 - TVHClient] Found 2 versions of android-support-v4.jar in the dependency list,
[2014-03-26 13:38:00 - TVHClient] but not all the versions are identical (check is based on SHA-1 only at this time).
[2014-03-26 13:38:00 - TVHClient] All versions of the libraries must be the same at this time.
[2014-03-26 13:38:00 - TVHClient] Versions found are:
[2014-03-26 13:38:00 - TVHClient] Path: C:\Users\Administrator\Documents\GitHub\android-support-v4-preferencefragment-master\libs\android-support-v4.jar
[2014-03-26 13:38:00 - TVHClient] Length: 621451
[2014-03-26 13:38:00 - TVHClient] SHA-1: 5896b0a4e377ac4242eb2bc785220c1c4fc052f4
[2014-03-26 13:38:00 - TVHClient] Path: C:\Users\Administrator\Documents\GitHub\appcompat\libs\android-support-v4.jar
[2014-03-26 13:38:00 - TVHClient] Length: 627582
[2014-03-26 13:38:00 - TVHClient] SHA-1: cb6883d96005bc85b3e868f204507ea5b4fa9bbf
[2014-03-26 13:38:00 - TVHClient] Jar mismatch! Fix your dependencies
[2014-03-26 13:38:01 - TVHClient] Found 2 versions of android-support-v4.jar in the dependency list,
[2014-03-26 13:38:01 - TVHClient] but not all the versions are identical (check is based on SHA-1 only at this time).
[2014-03-26 13:38:01 - TVHClient] All versions of the libraries must be the same at this time.
[2014-03-26 13:38:01 - TVHClient] Versions found are:
[2014-03-26 13:38:01 - TVHClient] Path: C:\Users\Administrator\Documents\GitHub\android-support-v4-preferencefragment-master\libs\android-support-v4.jar
[2014-03-26 13:38:01 - TVHClient] Length: 621451
[2014-03-26 13:38:01 - TVHClient] SHA-1: 5896b0a4e377ac4242eb2bc785220c1c4fc052f4
[2014-03-26 13:38:01 - TVHClient] Path: C:\Users\Administrator\Documents\GitHub\appcompat\libs\android-support-v4.jar
[2014-03-26 13:38:01 - TVHClient] Length: 627582
[2014-03-26 13:38:01 - TVHClient] SHA-1: cb6883d96005bc85b3e868f204507ea5b4fa9bbf
[2014-03-26 13:38:01 - TVHClient] Jar mismatch! Fix your dependencies
[2014-03-26 13:38:34 - TVHClient] Found 2 versions of android-support-v4.jar in the dependency list,
[2014-03-26 13:38:34 - TVHClient] but not all the versions are identical (check is based on SHA-1 only at this time).
[2014-03-26 13:38:34 - TVHClient] All versions of the libraries must be the same at this time.
[2014-03-26 13:38:34 - TVHClient] Versions found are:
[2014-03-26 13:38:34 - TVHClient] Path: C:\Users\Administrator\Documents\GitHub\android-support-v4-preferencefragment-master\libs\android-support-v4.jar
[2014-03-26 13:38:34 - TVHClient] Length: 621451
[2014-03-26 13:38:34 - TVHClient] SHA-1: 5896b0a4e377ac4242eb2bc785220c1c4fc052f4
[2014-03-26 13:38:34 - TVHClient] Path: C:\Users\Administrator\Documents\GitHub\appcompat\libs\android-support-v4.jar
[2014-03-26 13:38:34 - TVHClient] Length: 627582
[2014-03-26 13:38:34 - TVHClient] SHA-1: cb6883d96005bc85b3e868f204507ea5b4fa9bbf
[2014-03-26 13:38:34 - TVHClient] Jar mismatch! Fix your dependencies
[2014-03-26 13:38:38 - TVHClient] Found 2 versions of android-support-v4.jar in the dependency list,
[2014-03-26 13:38:38 - TVHClient] but not all the versions are identical (check is based on SHA-1 only at this time).
[2014-03-26 13:38:38 - TVHClient] All versions of the libraries must be the same at this time.
[2014-03-26 13:38:38 - TVHClient] Versions found are:
[2014-03-26 13:38:38 - TVHClient] Path: C:\Users\Administrator\Documents\GitHub\android-support-v4-preferencefragment-master\libs\android-support-v4.jar
[2014-03-26 13:38:38 - TVHClient] Length: 621451
[2014-03-26 13:38:38 - TVHClient] SHA-1: 5896b0a4e377ac4242eb2bc785220c1c4fc052f4
[2014-03-26 13:38:38 - TVHClient] Path: C:\Users\Administrator\Documents\GitHub\appcompat\libs\android-support-v4.jar
[2014-03-26 13:38:38 - TVHClient] Length: 627582
[2014-03-26 13:38:38 - TVHClient] SHA-1: cb6883d96005bc85b3e868f204507ea5b4fa9bbf
[2014-03-26 13:38:38 - TVHClient] Jar mismatch! Fix your dependencies
[2014-03-26 13:38:40 - TVHClient] Found 2 versions of android-support-v4.jar in the dependency list,
[2014-03-26 13:38:40 - TVHClient] but not all the versions are identical (check is based on SHA-1 only at this time).
[2014-03-26 13:38:40 - TVHClient] All versions of the libraries must be the same at this time.
[2014-03-26 13:38:40 - TVHClient] Versions found are:
[2014-03-26 13:38:40 - TVHClient] Path: C:\Users\Administrator\Documents\GitHub\android-support-v4-preferencefragment-master\libs\android-support-v4.jar
[2014-03-26 13:38:40 - TVHClient] Length: 621451
[2014-03-26 13:38:40 - TVHClient] SHA-1: 5896b0a4e377ac4242eb2bc785220c1c4fc052f4
[2014-03-26 13:38:40 - TVHClient] Path: C:\Users\Administrator\Documents\GitHub\appcompat\libs\android-support-v4.jar
[2014-03-26 13:38:40 - TVHClient] Length: 627582
[2014-03-26 13:38:40 - TVHClient] SHA-1: cb6883d96005bc85b3e868f204507ea5b4fa9bbf
[2014-03-26 13:38:40 - TVHClient] Jar mismatch! Fix your dependencies

@rsiebert
Copy link

Just copy the C:\Users\Administrator\Documents\GitHub\appcompat\libs\android-support-v4.jar to the preference fragment libs folder and replace the existing one. Both files need to be the same.

@ghost
Copy link

ghost commented Mar 26, 2014

sorry but i dont understand. Where i must copy android-support-v4.jar ?
To C:\Users\Administrator\Documents\GitHub\android-support-v4-preferencefragment-master\libs ?

@ghost
Copy link

ghost commented Mar 26, 2014

And tell me where is text with changelog ?

@rsiebert
Copy link

Hi, it is under TVHClient/res/raw/changelog

@ghost
Copy link

ghost commented Mar 26, 2014

Ok thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants