Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behaviour when invoked through deep links. #1267

Closed
Exulansis opened this issue Apr 9, 2019 · 4 comments
Closed

Fix behaviour when invoked through deep links. #1267

Exulansis opened this issue Apr 9, 2019 · 4 comments
Assignees
Labels

Comments

@Exulansis
Copy link
Collaborator

Describe the bug
If the wallet is invoked by some external application via a deep link, it does not always return control to the calling application. This depends on the callback specified in the callbackURL field of the interaction token.

To Reproduce
Steps to reproduce the behavior:

  1. Pass a deep link to the wallet with an interaction token and an http callbackURL (e.g. https://myservice.com/authentication)
  2. Go to the consent flow on the wallet
  3. Observe that after the response is sent, the wallet remains open.

Expected behavior
The wallet should invoke the initial calling application, regardless of the callbackURL

@Exulansis Exulansis added the bug label Apr 9, 2019
@Exulansis Exulansis self-assigned this Apr 9, 2019
@saifahn
Copy link

saifahn commented Apr 11, 2019

Duplicate of #1223? Or at least related, we should consolidate it into one issue?

@Exulansis
Copy link
Collaborator Author

Definitely related. We could set a tag / milestone for deep linking improvements. Although this one certainly holds priority.

@mnzaki
Copy link
Contributor

mnzaki commented Sep 19, 2019

@Exulansis is this still an issue?

@Exulansis
Copy link
Collaborator Author

It's no longer relevant. Can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants