Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deep link callback handling #1328

Closed
chunningham opened this issue Jun 12, 2019 · 4 comments
Closed

deep link callback handling #1328

chunningham opened this issue Jun 12, 2019 · 4 comments

Comments

@chunningham
Copy link
Contributor

Describe the bug
using a deep link as a callbackurl without an existing destination app results in an inescapable consent screen
@mnzaki
Copy link
Contributor

mnzaki commented Jun 13, 2019

Kind of related: sendCredentialResponse action cannot handle web callbacks if the incoming credentialRequest was through a deep link.
I don't think it should assume that the callback is a deep link

@chunningham chunningham changed the title deep link callback without existing destination fails deep link callback handling Jun 13, 2019
@chunningham
Copy link
Contributor Author

Extended issue to include inferring link action to take based on callbackURL format (deep link vs http(s)) and removing isDeepLinkInteraction from state

@mnzaki
Copy link
Contributor

mnzaki commented Jun 14, 2019

Also possibly related: #1223

@saifahn
Copy link

saifahn commented Jun 25, 2019

Closed via #1343

@saifahn saifahn closed this as completed Jun 25, 2019
@saifahn saifahn mentioned this issue Jun 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mnzaki @saifahn @chunningham