Add configuration options for consumer subscribing to a queue #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner service engine
Addition to fix jondot#417 Update DemoMiddleware to return worker result for property handling
We already have it as runtime dependency
Previously Sneakers was able to handle StandardError and ScriptError exceptions and their descendants. But there are more exceptions that could cause problems. * SystemStackError (stack level too deep) * NoMemoryError * custom descendants of Exception (e.g. declared by gems) In case of these exceptions, the handler is unable to report job state to the RabbitMQ. RabbitMQ keeps sending new jobs to the Sneakers until prefetch value reached. It makes Sneakers worker hang without processing any new message.
|
Sneakers now has a new home under https://github.com/ruby-amqp/kicks. May I ask you to re-submit this PR there? Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a worker subscribes to a queue only two configuration options were used
:block(hardcoded) and:ack(configurable using:ackoption). Setting other consumer configuration options such as consumer priorities or exclusive consumers was not possible.Creating new
consumer_optionsconfiguration options block resolves that and all configured consumer options are directly passed toqueue.subscribe(in more general way than pull request for exclusive consumers) while original defaults are kept as new defaults. The approach is similar toexchange_optionsandqueue_optionswhich are already in codebase. Old:ackconfiguration option becomes deprecated, but is mapped via deprecated options mapping.