Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve queue arguments when MaxRetry handler is used #427

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sharshenov
Copy link
Contributor

2.12.0+ versions of Sneakers have MaxRetry handler incompatible with custom queue arguments.

class AwesomeWorker
  include Sneakers::Worker

  from_queue 'awesome',
             handler: Sneakers::Handlers::Maxretry,
             arguments: {
               'x-max-priority' => 10 # <-- this argument is ignored
             }

  def work(_)
    ack!
  end
end

@sharshenov sharshenov force-pushed the maxretry-preserve-other-arguments branch from 81b6796 to 86e46e4 Compare February 18, 2020 23:21
@sharshenov
Copy link
Contributor Author

sharshenov commented Feb 19, 2020

Tests are failing for ruby-head like in master because of metric_fu-4.12.0

@mwannewitz
Copy link

What is the state of this PR? We would really like to make use of the suggested improvement.

@sharshenov sharshenov force-pushed the maxretry-preserve-other-arguments branch from 86e46e4 to 7a962d3 Compare October 27, 2020 18:06
@michaelklishin
Copy link
Collaborator

Sneakers now has a new home under https://github.com/ruby-amqp/kicks. May I ask you to re-submit this PR there? Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants