Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are these code right? #161

Open
zhaoyipeng opened this issue Oct 13, 2023 · 1 comment
Open

Are these code right? #161

zhaoyipeng opened this issue Oct 13, 2023 · 1 comment

Comments

@zhaoyipeng
Copy link

The 57-61 lines of tool_error.py are as follows

        for tool in gyro_continuous:
            if tool in self.em['codes']:
                self.gyro_continuous = []          #set gyro_continuous to empty list
                self.em['codes'].move_to_end(tool)
                self.gyro_continuous.append(tool)

My question is why always set gyro_continuous to empty list before append tool into gyro_continuous

@jonnymaserati
Copy link
Owner

Hi @zhaoyipeng

Sorry for the delay, I don't really get time to maintain this code these days.

No, that code doesn't look right. I never really finished the gyro error models, mostly because there's little to no diagnostic data that I could find to verify them, but I added what I did to the library in the hope that someone would pick it up and finish it off - so PRs are welcome if you fancy fixing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants