Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransformWizard.svelte is missing tbody tag inside table #485

Closed
mantulen opened this issue Sep 24, 2024 · 2 comments
Closed

TransformWizard.svelte is missing tbody tag inside table #485

mantulen opened this issue Sep 24, 2024 · 2 comments

Comments

@mantulen
Copy link

There is a breaking change in Svelte 5 that requires <tbody> tag in between <table> and <tr> or the below build error is raised, more info here:

sveltejs/svelte#9785

✘ [ERROR] node_modules/svelte-jsoneditor/components/modals/TransformWizard.svelte:94:2 `<tr>` is invalid inside `<table>` [plugin vite-plugin-svelte:optimize-svelte]

    node_modules/svelte-jsoneditor/components/modals/TransformWizard.svelte:94:2:
      94 │  <tr>
         ╵   ^

  The plugin "vite-plugin-svelte:optimize-svelte" was triggered by this import

    node_modules/svelte-jsoneditor/components/modals/TransformModal.svelte:21:28:
      21 │ import TransformWizard from './TransformWizard.svelte';
         ╵                             ~~~~~~~~~~~~~~~~~~~~~~~~~~

4:35:53 AM [vite] error while updating dependencies:
Error: Build failed with 1 error:
node_modules/svelte-jsoneditor/components/modals/TransformWizard.svelte:94:2: ERROR: [plugin: vite-plugin-svelte:optimize-svelte] node_modules/svelte-jsoneditor/components/modals/TransformWizard.svelte:94:2 `<tr>` is invalid inside `<table>`
    at failureErrorWithLog (/workspaces/cts-portal/src/frontend/node_modules/vite/node_modules/esbuild/lib/main.js:1472:15)
    at /workspaces/cts-portal/src/frontend/node_modules/vite/node_modules/esbuild/lib/main.js:945:25
    at /workspaces/cts-portal/src/frontend/node_modules/vite/node_modules/esbuild/lib/main.js:1353:9
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
@mantulen
Copy link
Author

mantulen commented Sep 24, 2024

Closing this as I see it is being addressed in the Svelte 5 PR:

#476

@josdejong
Copy link
Owner

Yeah, there are quite some issues upgrading to Svelte 5 though, we're not there yet 😅 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants