Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Configure Dimension instead of limiting to Nether/Overworld #4

Open
Dragnier opened this issue Jan 1, 2018 · 4 comments

Comments

@Dragnier
Copy link

Dragnier commented Jan 1, 2018

Is there any way you can make this where you can choose what dimension it works for instead of being limited? I'm considering making a pack with several dimensions and it would be cool to have control over fluids in all of them.

@josephcsible
Copy link
Owner

Between fluidsInsideNether and fluidsOutsideNether, this already controls all dimensions. Or do you mean you want fine-grained control over each dimension?

@Dragnier
Copy link
Author

Dragnier commented Jan 2, 2018

Ummm... lots of mods add dimensions. Extra Utilities 2, Twilight Forest, Aether Legacy, etc. Some even add ways to make dimensions, such as Simple Dimensions. All of these are uncontrollable with your mod because there is no way to specify the dim ID of the dimension being controlled.

The Overworld is 0, the Nether is -1, and the End is 1, Aether Legacy is 4, Twilight Forest is 7, and the Deep Dark from Extra Utilities 2 is 11325. Simple Dimensions lets modpack devs create dimensions and I think they get assigned ID's starting at around 30000 by default.

If you need examples of configs with something similar, check out CoFH World and In Control. There are probably lots of other examples, but those are two I can think of right off the top of my head.

@josephcsible
Copy link
Owner

I didn't say that no mods add other dimensions. I said that right now, my mod can control all dimensions. (And I know exactly how mod-added dimensions work already.) The way my code works now is that it checks doesWaterVaporize on the dimension's world provider, then uses fluidsInsideNether if it's true, or fluidsOutsideNether if it's false. So I repeat, do you mean you want fine-grained control over each dimension? If you want to be able to specify different settings for each dimension instead of just those two lists that apply to all dimensions, then say that.

@Dragnier
Copy link
Author

Dragnier commented Jan 2, 2018

Ah, sorry. I didn't realize those two lists affected other world providers like that. Totally my bad there. But yes, that is exactly what I'm talking about. The ability to directly control that setting per dimension outside of those lists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants