Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder GeometryAngle to conform intuitive Linestring thinking #150

Open
rukemn opened this issue Jan 27, 2020 · 2 comments
Open

Reorder GeometryAngle to conform intuitive Linestring thinking #150

rukemn opened this issue Jan 27, 2020 · 2 comments
Assignees
@jotoh98
Labels
👨‍💻 WIP Somebody is still working on this

Comments

@rukemn
Copy link
Collaborator

rukemn commented Jan 27, 2020

Reorder center,left, right
to
right, center, left OR left,center,right
@DorianRec
Copy link
Collaborator

DorianRec commented Mar 7, 2020 •
edited
Loading

I thought we unified on and implemented (left, center, right),
since Angle.angleBetween(tip1, tail, tip2) is implemented that way (https://locationtech.github.io/jts/javadoc/org/locationtech/jts/algorithm/Angle.html#angleBetween-org.locationtech.jts.geom.Coordinate-org.locationtech.jts.geom.Coordinate-org.locationtech.jts.geom.Coordinate-).

If we have, why did we reordered to (center, left, right) ?

@jotoh98 jotoh98 mentioned this issue Mar 20, 2020
Closed
@DorianRec DorianRec added the 👨‍💻 WIP Somebody is still working on this label Mar 20, 2020
@DorianRec DorianRec assigned DorianRec and jotoh98 and unassigned DorianRec Mar 20, 2020
@jotoh98
Copy link
Owner

jotoh98 commented Mar 23, 2020

Do we merge PR #153 after merging master with the implemented strategies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jotoh98 jotoh98

Labels
👨‍💻 WIP Somebody is still working on this
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bring geometry angle in correct order (left, center, right) jotoh98/treasureHunt
3 participants
@DorianRec @jotoh98 @rukemn