Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/#183 missing linesegment in linestring #185

Closed
wants to merge 34 commits into from

Conversation

DorianRec
Copy link
Collaborator

@DorianRec DorianRec commented Mar 7, 2020

Since this contains the code of the branch 51-make-geometryitems-clickable, solve PR #95 first.

Changes:

  • All changes of PR Feature/#51 make geometryitems clickable #95
  • Effectively made the SearchPath containing all Points of the search path, instead of lacking the first one. This makes the usage of this class much more easy, since we do not need to know the first point of the search path in order to request the search path.
  • Added a bunch of SearchPath - tests.

Issues:

Fixes #183

DorianRec and others added 30 commits January 14, 2020 00:11
# Conflicts:
#	src/main/java/com/treasure/hunt/game/GameManager.java
#	src/main/java/com/treasure/hunt/strategy/hider/impl/RandomAngleHintHider.java
#	src/main/java/com/treasure/hunt/utils/EventBusUtils.java
#	src/main/java/com/treasure/hunt/view/MainController.java
# Conflicts:
#	src/main/java/com/treasure/hunt/game/GameManager.java
#	src/main/java/com/treasure/hunt/jts/geom/Circle.java
#	src/main/java/com/treasure/hunt/strategy/geom/GeometryItem.java
# Conflicts:
#	src/main/java/com/treasure/hunt/strategy/geom/GeometryItem.java
#	src/main/java/com/treasure/hunt/strategy/geom/GeometryStyle.java
#	src/main/java/com/treasure/hunt/strategy/geom/GeometryType.java
#	src/main/java/com/treasure/hunt/view/CanvasController.java
# Conflicts:
#	src/main/java/com/treasure/hunt/game/GameEngine.java
#	src/main/java/com/treasure/hunt/game/GameManager.java
#	src/main/java/com/treasure/hunt/strategy/geom/GeometryType.java
#	src/main/java/com/treasure/hunt/strategy/hider/impl/MaxAreaAngularHintStrategy.java
#	src/main/java/com/treasure/hunt/strategy/searcher/impl/NaiveAngleSearcher.java
#	src/main/java/com/treasure/hunt/utils/JTSUtils.java
#	src/main/java/com/treasure/hunt/utils/Renderer.java
@1-alex98
Copy link
Collaborator

1-alex98 commented Mar 9, 2020

Ahhh Dorian

@@ -31,7 +31,7 @@ public void testRemoveGeometryItems() {
throw new RuntimeException(e);
}

instance.next();
instance.next(); // TODO fix
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is not helpful, create an issue and reference the issue

@DorianRec DorianRec closed this Mar 9, 2020
@DorianRec DorianRec deleted the bugfix/#183-missing-linesegment-in-linestring branch March 16, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Append the missing first LineSegment to the SearchPath
2 participants